Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]Provide an interface for transaction's writeSetChange, in order to compare the change of resources #3779

Open
ssyuan opened this issue Oct 11, 2022 · 1 comment · May be fixed by #3903
Open

[Feature Request]Provide an interface for transaction's writeSetChange, in order to compare the change of resources #3779

ssyuan opened this issue Oct 11, 2022 · 1 comment · May be fixed by #3903
Assignees
@welbon
Labels
enhancement Enhancement

Comments

@ssyuan
Copy link
Member

ssyuan commented Oct 11, 2022

Feature Request

Describe the Feature Request
Provide an interface for transaction's writeSetChange, in order to compare the change of resources

Describe Preferred Solution

Used to show in the browser that a transaction has occurred that affects those resources

example：
https://explorer.aptoslabs.com/txn/259143996
@ssyuan ssyuan added the enhancement Enhancement label Oct 11, 2022
@nkysg nkysg self-assigned this Oct 13, 2022
@jolestar jolestar assigned sanlee42 and unassigned nkysg Nov 18, 2022
@nkysg
Copy link
Collaborator

nkysg commented Nov 28, 2022

move-language/move#373 In this link , MoveVM has changed the change_set storage operation, in
language/move-core/types/src/effects.rs,

/// A storage operation.
#[derive(Debug, Clone, Eq, PartialEq, Ord, PartialOrd)]
pub enum Op<T> {
    /// Inserts some new data into an empty slot.
    New(T),
    /// Modifies some data that currently exists.
    Modify(T),
    /// Deletes some data that currently exists.
    Delete,
}

In starcoin dev_gas_meter branch, we can add these code blob to deltachangeset

starcoin/vm/vm-runtime/src/move_vm_ext/session.rs

Lines 103 to 109 in 9f35588

let ap = ap_cache.get_module_path(ModuleId::new(addr, name));
let op = match blob_opt {
MoveStorageOp::Delete => WriteOp::Deletion,
MoveStorageOp::New(blob) => WriteOp::Value(blob),
MoveStorageOp::Modify(blob) => WriteOp::Value(blob),
};

I think it should change TransactionOutput and we need to compatible

@nkysg nkysg assigned welbon and unassigned sanlee42 Jun 1, 2023
@nkysg nkysg linked a pull request Jun 1, 2023 that will close this issue
Transaction writeset store #3903
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@welbon welbon

Labels
enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transaction writeset store starcoinorg/starcoin
4 participants
@ssyuan @sanlee42 @welbon @nkysg