[Bug] pre-commit workflow is broken

[ulgens]

What happened?

When I try to run pre-commit run --all-files in the repo, it generates a huge diff with 338 affected files. Considering the pre-commit setup was in place for a while, running this command on the main branch shouldn't change any file.

I checked what's going on with the related CI workflow and apparently, it's been broken for a while:

The workflow is not valid. .github/workflows/precommits_check.yml (Line: 18, Col: 5): Required property is missing: runs-on

https://github.com/stanfordnlp/dspy/actions/runs/8059208679

Steps to reproduce

• Run pre-commit run --all-files on the main branch's latest
• Check the git status output

DSPy version

main

[ulgens]

I'd like to fix this issue and apply fixes to the repo, and then update and improve the pre-commit config. My initial goal was to clean the residues left from Python 3.8* and then add pyupgrade to the repo; but it turned out that pre-commit config needs some work first.

* PyPI is using the misleading metadata:

[chenmoneygithub]

@ulgens Thanks for reporting the issue! We are not enforcing pre-commit rules right now. Exactly as you have observed, running autoformatting will generate a huge diff list. We are in the middle of standardizing the coding style, and will fix it in a progressive way to avoid breakage.

[ulgens]

@chenmoneygithub Thanks for your response. I have already started fixing this issue and handling a couple of related issues around it. Currently, #7826 is ready for review. I have 3 other PRs open and waiting, which demonstrates the path I'm planning to follow:

• fix: Enable pre-commit CI workflow on pull requests #7824
• pre-commit-hooks #7827
• Isort #7828

The last two are relatively big but I believe it's inevitable at this point.

If we follow up with the existing PRs, I could also help with #7885 (review)