Skip to content
This repository was archived by the owner on Jun 15, 2022. It is now read-only.

Commit f345c14

Browse files
committed
fix: mobile selected text turned off on codemirror
1 parent 057a28a commit f345c14

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

Diff for: src/main.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ document.addEventListener("DOMContentLoaded", function(event) {
7676
editor = CodeMirror.fromTextArea(document.getElementById("code"), {
7777
mode: "markdown",
7878
lineWrapping: true,
79-
styleSelectedText: true,
79+
styleSelectedText: !isMobile(),
8080
extraKeys: {"Alt-F": "findPersistent"}
8181
});
8282
editor.setSize("100%", "100%");
@@ -87,6 +87,14 @@ document.addEventListener("DOMContentLoaded", function(event) {
8787
});
8888
}
8989

90+
var isMobile = function () {
91+
var check = false;
92+
(function (a) {
93+
if (/(android|bb\d+|meego).+mobile|avantgo|bada\/|blackberry|blazer|compal|elaine|fennec|hiptop|iemobile|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|mobile.+firefox|netfront|opera m(ob|in)i|palm( os)?|phone|p(ixi|re)\/|plucker|pocket|psp|series(4|6)0|symbian|treo|up\.(browser|link)|vodafone|wap|windows ce|xda|xiino|android|ipad|playbook|silk/i.test(a) || /1207|6310|6590|3gso|4thp|50[1-6]i|770s|802s|a wa|abac|ac(er|oo|s-)|ai(ko|rn)|al(av|ca|co)|amoi|an(ex|ny|yw)|aptu|ar(ch|go)|as(te|us)|attw|au(di|-m|r |s )|avan|be(ck|ll|nq)|bi(lb|rd)|bl(ac|az)|br(e|v)w|bumb|bw-(n|u)|c55\/|capi|ccwa|cdm-|cell|chtm|cldc|cmd-|co(mp|nd)|craw|da(it|ll|ng)|dbte|dc-s|devi|dica|dmob|do(c|p)o|ds(12|-d)|el(49|ai)|em(l2|ul)|er(ic|k0)|esl8|ez([4-7]0|os|wa|ze)|fetc|fly(-|_)|g1 u|g560|gene|gf-5|g-mo|go(\.w|od)|gr(ad|un)|haie|hcit|hd-(m|p|t)|hei-|hi(pt|ta)|hp( i|ip)|hs-c|ht(c(-| |_|a|g|p|s|t)|tp)|hu(aw|tc)|i-(20|go|ma)|i230|iac( |-|\/)|ibro|idea|ig01|ikom|im1k|inno|ipaq|iris|ja(t|v)a|jbro|jemu|jigs|kddi|keji|kgt( |\/)|klon|kpt |kwc-|kyo(c|k)|le(no|xi)|lg( g|\/(k|l|u)|50|54|-[a-w])|libw|lynx|m1-w|m3ga|m50\/|ma(te|ui|xo)|mc(01|21|ca)|m-cr|me(rc|ri)|mi(o8|oa|ts)|mmef|mo(01|02|bi|de|do|t(-| |o|v)|zz)|mt(50|p1|v )|mwbp|mywa|n10[0-2]|n20[2-3]|n30(0|2)|n50(0|2|5)|n7(0(0|1)|10)|ne((c|m)-|on|tf|wf|wg|wt)|nok(6|i)|nzph|o2im|op(ti|wv)|oran|owg1|p800|pan(a|d|t)|pdxg|pg(13|-([1-8]|c))|phil|pire|pl(ay|uc)|pn-2|po(ck|rt|se)|prox|psio|pt-g|qa-a|qc(07|12|21|32|60|-[2-7]|i-)|qtek|r380|r600|raks|rim9|ro(ve|zo)|s55\/|sa(ge|ma|mm|ms|ny|va)|sc(01|h-|oo|p-)|sdk\/|se(c(-|0|1)|47|mc|nd|ri)|sgh-|shar|sie(-|m)|sk-0|sl(45|id)|sm(al|ar|b3|it|t5)|so(ft|ny)|sp(01|h-|v-|v )|sy(01|mb)|t2(18|50)|t6(00|10|18)|ta(gt|lk)|tcl-|tdg-|tel(i|m)|tim-|t-mo|to(pl|sh)|ts(70|m-|m3|m5)|tx-9|up(\.b|g1|si)|utst|v400|v750|veri|vi(rg|te)|vk(40|5[0-3]|-v)|vm40|voda|vulc|vx(52|53|60|61|70|80|81|83|85|98)|w3c(-| )|webc|whit|wi(g |nc|nw)|wmlb|wonu|x700|yas-|your|zeto|zte-/i.test(a.substr(0, 4))) check = true;
94+
})(navigator.userAgent || navigator.vendor || window.opera);
95+
return check;
96+
};
97+
9098
loadEditor();
9199
loadComponentManager();
92100
});

Diff for: src/main.scss

+15-3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ body, html {
33
font-size: var(--sn-stylekit-base-font-size);
44
height: 100%;
55
margin: 0;
6+
background-color: transparent;
7+
}
8+
9+
* {
10+
// To prevent gray flash when focusing input on mobile Safari
11+
-webkit-tap-highlight-color: rgba(0,0,0,0);
612
}
713

814
#wrapper {
@@ -41,12 +47,17 @@ body, html {
4147

4248
&.CodeMirror-selectedtext {
4349
color: var(--sn-stylekit-info-contrast-color) !important;
44-
background: transparent;
50+
background: var(--sn-stylekit-info-color) !important;
4551
}
4652
}
4753

4854
.cm-header {
4955
color: var(--sn-stylekit-editor-foreground-color);
56+
57+
&.CodeMirror-selectedtext {
58+
color: var(--sn-stylekit-info-contrast-color) !important;
59+
background: var(--sn-stylekit-info-color) !important;
60+
}
5061
}
5162

5263
// Faded Markdown syntax
@@ -68,7 +79,7 @@ body, html {
6879

6980
&.CodeMirror-selectedtext {
7081
color: var(--sn-stylekit-info-contrast-color) !important;
71-
background: transparent;
82+
background: var(--sn-stylekit-info-color) !important;
7283
}
7384
}
7485

@@ -79,7 +90,7 @@ body, html {
7990
}
8091

8192
.CodeMirror-cursor {
82-
border-color: var(--sn-stylekit-editor-foreground-color-color);
93+
border-color: var(--sn-stylekit-editor-foreground-color);
8394
}
8495

8596
.CodeMirror-selected {
@@ -88,6 +99,7 @@ body, html {
8899

89100
.CodeMirror-selectedtext {
90101
color: var(--sn-stylekit-info-contrast-color) !important;
102+
background: var(--sn-stylekit-info-color) !important;
91103
}
92104

93105
.CodeMirror-gutters {

0 commit comments

Comments
 (0)