Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display slatepacks as QR codes in CLI #12

Open
stakervali opened this issue Oct 11, 2021 · 8 comments · Fixed by mimblewimble/grin-wallet#655
Open

Display slatepacks as QR codes in CLI #12

stakervali opened this issue Oct 11, 2021 · 8 comments · Fixed by mimblewimble/grin-wallet#655

Comments

@stakervali
Copy link
Owner

@cliik
Copy link

cliik commented Jul 5, 2022

Hi, I am interested in taking on this wishlist item. I've already done similar work in the CLI:
mimblewimble/grin-wallet#650

Is anyone else already working on this? If not, what are the requirements for this feature? My initial impression is this is just a CLI change, so no need to update the owner API. If so, I think this should be a painless addition.

@stakervali
Copy link
Owner Author

Hi @cliik, AFAIK there is no bounty for this item nor anyone working on this.

@cliik
Copy link

cliik commented Jul 8, 2022

Hi @cliik, AFAIK there is no bounty for this item nor anyone working on this.

Ok great. I will look into this and may take it on next week, depending on my schedule.

@cliik
Copy link

cliik commented Jul 9, 2022

@stakervali does this satisfy your request?

mimblewimble/grin-wallet#655

@cliik
Copy link

cliik commented Jul 9, 2022

@stakervali should this wishlist item be moved to "in progress" on https://grincc.mw/projects? I don't need a bounty, but it is in progress none the less 😄

@stakervali
Copy link
Owner Author

stakervali commented Jul 10, 2022

Hi @cliik
If you open a forum post, I can add link. Also do milestones look good below?

(Or implementation of QR code display in grin-wallet ?)

image

@cliik
Copy link

cliik commented Jul 11, 2022

@stakervali The milestones look fine, but one small change to the description: This project aims to improve 'grin-wallet CLI', not 'Grin++ project.

If you open a forum post, I can add link.

What do you want me to ask in the forums? Just to ask people to review the PR and submit feedback?

@stakervali
Copy link
Owner Author

Hi @cliik, sorry for late reply, I forgot to reply and close the tab with other 100 tabs I opened.
I meant a small post at forum for informing community about your work. I updated grincc.mw, added this to finished projects category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants