FinalizedWithdrawRequest confusing semantics

[jac18281828]

there are multiple withdrawal settlement/finalization IDs, and there is enough ETH in the contract for the finalizations to take place. However, when we run the job, only one finalization (ID) is settled, the rest remain in the same status. Our understanding is that if there is enough ETH, all the IDs should have been settled.

The issue appears to be with the below referenced code. The finalization is somewhat confusing because each finalized Id is not reported. The FinalizedWithdrawRequest(uint) event indicates the highest requestId plus 1 that was finalized. It would make sense to report each requestId that has been finalized. It appears that the finalization is working properly but this ticket indicates that the implementation is confusing.

ethx/contracts/UserWithdrawalManager.sol

Line 171 in f545abe

if (requestId > nextRequestIdToFinalize) {

[jac18281828]

@vagpm 👀