Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.hook.update() unable to update entire hook object #6

Open
andrewtlove opened this issue Aug 26, 2016 · 2 comments
Open

client.hook.update() unable to update entire hook object #6

andrewtlove opened this issue Aug 26, 2016 · 2 comments

Comments

@andrewtlove
Copy link

I've noticed that the update() method only updates some fields. For example, the customTimeout parameter can only be set at hook creation, but not later modified through client.hook.update().

In another instance, a parameter may only be modified in a particular way. For example, one is permitted to modify the parameters isPublic from false --> true, but not from true --> false. The opposite is true for isPrivate.

Perhaps there's a good reason for this, but I've not been able to decipher why this is occurring just yet.

@Marak
Copy link
Collaborator

Marak commented Aug 26, 2016

The entry-point for update is /view/admin.js, new hooks is /view/new.js

I've been updating admin.js file recently and will check out the problem with boolean type updates / missing properties.

@Marak
Copy link
Collaborator

Marak commented Aug 26, 2016

Would be good to add tests for hook updating here: https://github.com/bigcompany/hook.io-test/tree/master/tests/client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants