Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOM issue in int-to-ascii and int-to-utf8 #592

Closed
Acaccia opened this issue Dec 30, 2024 · 0 comments · Fixed by #599
Closed

OOM issue in int-to-ascii and int-to-utf8 #592

Acaccia opened this issue Dec 30, 2024 · 0 comments · Fixed by #599
Assignees
Labels
bug Something isn't working good first issue Good for newcomers wasm

Comments

@Acaccia
Copy link
Collaborator

Acaccia commented Dec 30, 2024

Here are some tests that show the failures of those functions:

#[test]
fn int_to_ascii_oom() {
    crosscheck_oom(
        "(int-to-ascii 42)",
        Ok(Some(
            Value::string_ascii_from_bytes(b"42".to_vec()).unwrap(),
        )),
    );
}

#[test]
fn int_to_utf8_oom() {
    crosscheck_oom(
        "(int-to-utf8 42)",
        Ok(Some(Value::string_utf8_from_bytes(b"42".to_vec()).unwrap())),
    );
}

(These tests will exists after the merging of #586)

@Acaccia Acaccia added bug Something isn't working good first issue Good for newcomers wasm labels Dec 30, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Dec 30, 2024
@Acaccia Acaccia changed the title OOM issue in string-to-ascii and string-to-utf8 OOM issue in int-to-ascii and int-to-utf8 Dec 30, 2024
@BowTiedWoo BowTiedWoo self-assigned this Jan 11, 2025
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers wasm
Projects
Status: Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants