Skip to content

Commit c2145df

Browse files
authored
chore: Remove hardcoded uid and gid (#637)
1 parent 93883ce commit c2145df

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
- test: Bump to Vector `0.46.1` ([#628]).
2424
- test: Bump OPA to `1.4.2` ([#631]).
2525
- Use versioned common structs ([#635]).
26+
- BREAKING: Previously this operator would hardcode the UID and GID of the Pods being created to 1000/0, this has changed now ([#637])
27+
- The `runAsUser` and `runAsGroup` fields will not be set anymore by the operator
28+
- The defaults from the docker images itself will now apply, which will be different from 1000/0 going forward
29+
- This is marked as breaking because tools and policies might exist, which require these fields to be set
2630

2731
### Fixed
2832

@@ -38,6 +42,7 @@
3842
[#628]: https://github.com/stackabletech/superset-operator/pull/628
3943
[#631]: https://github.com/stackabletech/superset-operator/pull/631
4044
[#635]: https://github.com/stackabletech/superset-operator/pull/635
45+
[#637]: https://github.com/stackabletech/superset-operator/pull/637
4146

4247
## [25.3.0] - 2025-03-21
4348

rust/operator-binary/src/druid_connection_controller.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -344,12 +344,7 @@ async fn build_import_job(
344344
image_pull_secrets: resolved_product_image.pull_secrets.clone(),
345345
restart_policy: Some("Never".to_string()),
346346
service_account: Some(sa_name.to_string()),
347-
security_context: Some(
348-
PodSecurityContextBuilder::new()
349-
.run_as_user(1000)
350-
.run_as_group(0)
351-
.build(),
352-
),
347+
security_context: Some(PodSecurityContextBuilder::new().build()),
353348
..Default::default()
354349
}),
355350
};

rust/operator-binary/src/superset_controller.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -755,8 +755,6 @@ fn build_server_rolegroup_statefulset(
755755
.image_pull_secrets_from_product_image(resolved_product_image)
756756
.security_context(
757757
PodSecurityContextBuilder::new()
758-
.run_as_user(1000)
759-
.run_as_group(0)
760758
.fs_group(1000) // Needed for secret-operator
761759
.build(),
762760
)

0 commit comments

Comments
 (0)