-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with foreign CultureInfo #9
Comments
I don't believe hb-100, the original author, took this into account, and I've likewise not taken this into account either. A PR would be great :). |
Hi, i have problems when run fsearthmask, because i have the spanish (Argentina) cultureInfo.
|
Any updates on a pull request with these fixes? |
Hi, I haven't had time to do a proper pull request. Sorry Edit: Looks like FSET now support MSFS, great ! I might give this a shot again... |
Hello,
First, thanks for this usefull software !
I've had some issues to run it, though.
There are some bugs when this is running on a plateform that use another CultureInfo (== "locale"). For example, my Windows is in french (CultureInfo('fr-FR')) and strings are thus not properly handled.
In french, we use this format "123,45" for a decimal number (and not "123.45"). I assume this is probably the case for other languages as well.
I will provide a pull request later this week when I figure where to force the CultureInfo to "en-US" or if I find another cleaner way.
In the meantime, I managed to compile it and run it successfully by placing
Thread.CurrentThread.CurrentCulture = new CultureInfo("en-US");
at different places in the codebase but it's not very clean.
The text was updated successfully, but these errors were encountered: