Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned pgstac dependencies? #5

Open
duckontheweb opened this issue Aug 6, 2022 · 0 comments
Open

Pinned pgstac dependencies? #5

duckontheweb opened this issue Aug 6, 2022 · 0 comments

Comments

@duckontheweb
Copy link
Contributor

Ported from stac-utils/stac-fastapi#369

Original Issue:

Hi there,
Thanks for a great set of libraries -so helpful!

One thing I encountered in getting things running locally using Docker was that some of my searches weren't working as expected - in trawling through tickets I saw there had been some recent improvements upstream in pgstac and the pypgstac dependencies. I noticed they were pinned in a few spots.

docker-compose.yaml
https://github.com/stac-utils/stac-fastapi/blob/6c22bad84422151ed2ddfe53dd5242f7f83772d3/docker-compose.yml#L68

stac_fastapi/pgstac/setup.py
https://github.com/stac-utils/stac-fastapi/blob/6c22bad84422151ed2ddfe53dd5242f7f83772d3/stac_fastapi/pgstac/setup.py#L28

Updating these to the latest resolved my issues so I was wondering if there was a reason they should be pinned or if you'd be happy to accept a PR pointing to the latest versions, or with the pin removed?

Cheers
Rowan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant