-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Temporarily disable adsorber #22
Comments
Hi @eksperimental, For this purpose there's the option
That means:
|
Sounds like a hack,
|
I kinda like that idea,
so there should be the following new operations (actually aliases to existing ones) for alignment with Systemd:
- `adsorber enable` as `adsorber setup`
- `adsorber disable` stays the same
- `adsorber start` as `adsorber update`
- `adsorber stop` as ` adsorber restore`
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Wednesday, November 17th, 2021 at 4:27 PM, Eksperimental ***@***.***> wrote:
Sounds like a hack,
I think we could have two new commands more aligned to the action of systemd.
stop - disable the systemd services and disables the entires in the host fles.
start - set it back up
—
You are receiving this because you commented.
Reply to this email directly, [view it on GitHub](#22 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AH7DLD7LLYK6C2IHA3VTYRLUMPCU5ANCNFSM5H2QVYCA).
Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).
|
But I wouldn't disable the Systemd service with `adsorber stop` as there is `adsorber disable` which does exactly that.
|
enable installs the systemd services, disable removes them. |
NOTE: I am not a systemd expert. that I just my vague assumption of how they work. UPDATE updates the host files. I think we should not use it for when we want to temporarily block/unblock connections |
For me the analogy of "stop" and "start" is about filtering, not the Systemd service.
- "start" filtering of ads
- "stop" filtering of ads
Therefore I suggest changing it like my in my previous message.
|
@eksperimental release it out. Can this be closed? |
Sorry, I was busy with other stuff, I got sidetracked.. thank you.! |
I think
|
also, the README instructions should include instructions for UPDATING adsorber, not only for installing. |
Another action that could be added is |
A small new release for Adsorber is coming through soon. I improved the updating capabilities of the install script. Therefore UPDATING will be the same as installing Adsorber :) |
There are times when I need to temporarily disable Adsorber, just to check a website the way it normally is, or sometimes when I need to follow a redirected link which its URL is blocked.
This feature could convert to comments all relevant entries.. and un-comment then once re-enabled.
It could also be a feature like,, disable for X amount of time (default 5 minutes).
The text was updated successfully, but these errors were encountered: