Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix matcher not working with i18n #518

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

conico974
Copy link
Contributor

@conico974 conico974 commented Sep 17, 2024

This PR fix the matcher not working for the default locale in headers from next.config and the matcher from the middleware
Fix #516

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 661ef98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 6:12pm

@conico974 conico974 changed the title fix middleware matcher not working with i18n fix matcher not working with i18n Sep 20, 2024
@conico974 conico974 merged commit 4ec9265 into opennextjs:main Sep 22, 2024
3 checks passed
@conico974 conico974 deleted the fix/middleware-i18n-matcher branch October 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matcher-based middleware is not invoked when i18n is configured
2 participants