Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add unit and e2e testing #178

Merged
merged 26 commits into from
Aug 31, 2023
Merged

Feat: Add unit and e2e testing #178

merged 26 commits into from
Aug 31, 2023

Conversation

khuezy
Copy link
Contributor

@khuezy khuezy commented Aug 16, 2023

fixes: #118

This PR adds unit/e2e testing and @open-next packages for modular development and testing, but currently, open-next does not import the @open-next/utils package b/c doing so would change the dist output and I didn't want to deal w/ that yet.

You can test this locally by running: pnpm run dev to run the next apps and then pnpm run e2e:test
You can test against a deployed app by setting the proper env variable:

/examples/sst

export APP_DIR_ONLY_URL=$(jq -r '.["e2e-example-AppDirOnly"].url' .sst/outputs.json)
export PAGES_ONLY_URL=$(jq -r '.["e2e-example-PagesOnly"].url' .sst/outputs.json)
export APP_DIR_AND_PAGES_URL=$(jq -r '.["e2e-example-AppDirAndPages"].url' .sst/outputs.json)

The current Nextjs Version is 13.4.12 (last stable version). But once the open PRs are merged to address the issues, we'll want to set the version to latest

todo:

  • Add AppDir + Pages project
  • Add more scenarios

@fwang

  • Add SST credentials to project for deployment
  • Validate that the e2e.yml is properly configured

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 10:17pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

⚠️ No Changeset found

Latest commit: f4285c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seed-deploy seed-deploy bot temporarily deployed to pr178 August 23, 2023 21:06 Inactive
@khuezy khuezy marked this pull request as ready for review August 27, 2023 23:40
@khuezy
Copy link
Contributor Author

khuezy commented Aug 27, 2023

I'm having trouble setting up the aws credentials :/

@khuezy khuezy merged commit 904e6e6 into opennextjs:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Add unit testing
4 participants