Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.install does not work in SolidStart site #1110

Open
ian-pascoe opened this issue Sep 20, 2024 · 5 comments
Open

server.install does not work in SolidStart site #1110

ian-pascoe opened this issue Sep 20, 2024 · 5 comments
Assignees

Comments

@ian-pascoe
Copy link
Contributor

ian-pascoe commented Sep 20, 2024

When I try to deploy my solidstart site and add installs to the server function, they are not added.

To reproduce:

  1. Use SolidStart example
  2. Add server.install option
  3. Check deployed code and see that install was not executed
@fwang
Copy link
Contributor

fwang commented Sep 21, 2024

You are right. server.install has no effect on SolidStart sites. SolidStart uses Nitro behind the scene. Nitro packages the lambda code into .output/server. And SolidStart uses it as is.

What packages are you trying to bundle into the server lambda code?

@ian-pascoe
Copy link
Contributor Author

I am trying to have sentry packages installed for instrumentation. The sentry docs want your sentry init file to be called via NODE_OPTIONS=‘—import instrumentation.mjs’ which makes it get shaken during build

@fwang
Copy link
Contributor

fwang commented Sep 21, 2024

Can u check if it can be configured in app.config.ts to include specific npm packages in the server build output?

/cc @thdxr do u know if it's possible?

@ian-pascoe
Copy link
Contributor Author

I have tried several config options but it keeps getting shaken. I am about to go the lambda layer route if I can’t figure it out

@fwang
Copy link
Contributor

fwang commented Sep 21, 2024

Just talked to @thdxr, he's working on some stuff in this area. He will fix this.

For context, SolidStart's server output looks like this:
Screen Shot 2024-09-21 at 3 45 08 PM

We could inject server.install in package.json, and run npm install.

@fwang fwang assigned thdxr and unassigned fwang Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants