Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add booleans for parameters turning functionality off and on #61

Open
ssm opened this issue Mar 3, 2019 · 1 comment
Open

Add booleans for parameters turning functionality off and on #61

ssm opened this issue Mar 3, 2019 · 1 comment
Labels
help wanted I would appreciate some help to get this fixed question
Milestone

Comments

@ssm
Copy link
Owner

ssm commented Mar 3, 2019

The following parameters should be booleans, with the current values deprecated (but still working)

  • munin::master::tls Enum['enabled','disabled']
  • munin::master::tls_verify_certificate Enum['yes','no']
  • munin::node::export_node: Enum['enabled','disabled']

The current release is 0.2.0. With semantic versioning, 0.x means "no promises", but the module has a lot of users, and I value API stability.

Should these be deprecated in a "0.3.0" release and removed in 1.0.0, or deprecated in 1.0.0 and removed in 2.0.0?

Comments welcome...

@ssm ssm added this to the 1.0.0 milestone Mar 3, 2019
@ssm ssm added the help wanted I would appreciate some help to get this fixed label Mar 3, 2019
@ssm ssm removed this from the 1.0.0 milestone Mar 3, 2019
@ssm ssm added the question label Mar 3, 2019
@ssm ssm added this to the 1.0.0 milestone Mar 4, 2019
@mhjacks
Copy link
Contributor

mhjacks commented Mar 4, 2019

I would vote for deprecation in 0.3.0 and removal in 1.0.0. Major versions are "permission" in semver to do breaking changes. I completely understand your reluctance to break API, but the underlying language has changed a lot since you released 0.1.0, too. :)

@ssm ssm changed the title Inconsistent use of booleans and enum for turning functionality off and on. Add booleans for turning functionality off and on Jun 30, 2020
@ssm ssm changed the title Add booleans for turning functionality off and on Add booleans for parameters turning functionality off and on Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted I would appreciate some help to get this fixed question
Projects
None yet
Development

No branches or pull requests

2 participants