-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Error : : Using Sigstore / Cosign validation with 'auth.k8sKeychain.true' for Connaisseur from application version 3.6.0 and chart version 2.6.0 is broken #1766
Comments
cc @phbelitz and @chrysogonus |
edison-vflow
changed the title
Using Sigstore / Cosign validation with 'auth.k8sKeychain.true' for Connaisseur from application version 3.6.0 and chart version 2.6.0 is broken
Documentation Error : : Using Sigstore / Cosign validation with 'auth.k8sKeychain.true' for Connaisseur from application version 3.6.0 and chart version 2.6.0 is broken
Sep 23, 2024
OMG this issue literally took us around 3 weeks of debugging |
phbelitz
added a commit
that referenced
this issue
Sep 27, 2024
The `--k8-keychain` feature provided by cosign is supported by Connaisseur with the `auth.k8sKeychain` option in validator configurations. This option was internally renamed to `auth.useKeychain` without mentioning this change inside the documentation. This has been fixed. fixes #1766
phbelitz
added a commit
that referenced
this issue
Sep 27, 2024
The `--k8-keychain` feature provided by cosign is supported by Connaisseur with the `auth.k8sKeychain` option in validator configurations. This option was internally renamed to `auth.useKeychain` without mentioning this change inside the documentation. This has been fixed. fixes #1766
phbelitz
added a commit
that referenced
this issue
Sep 27, 2024
The `--k8-keychain` feature provided by cosign is supported by Connaisseur with the `auth.k8sKeychain` option in validator configurations. This option was internally renamed to `auth.useKeychain` without mentioning this change inside the documentation. This has been fixed. fixes #1766
phbelitz
added a commit
that referenced
this issue
Sep 27, 2024
The `--k8-keychain` feature provided by cosign is supported by Connaisseur with the `auth.k8sKeychain` option in validator configurations. This option was internally renamed to `auth.useKeychain` without mentioning this change inside the documentation. This has been fixed. fixes #1766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
auth.k8sKeychain
authentication mechanism, this no longer works.When you set your validator to use auth.k8sKeychain.true , the pods throw an error on startup
We were on Connaisseur application version 3.0.0 and chart version 2.0.0
When we upgraded to application version 3.6.0 and chart version 2.6.0, there was this issue of misconfigured secret
We reported it and it was resolved in issue #1734 via PR #1735
Even after this fix , we got the error highlighted above.We tried several things but nothing documented seemed to work.
So we stopped trying to use
auth.k8sKeychain.true
which we had been using all along in the lower versions i.eConnaisseur application version 3.0.0 and chart version 2.0.0
We started trying to use
auth.secretName
and thats where we encountered the 2 issues raised here:When we had the issue with
auth.secretName
, we evaluated various approaches we can use to fix the fact that the Connaisseur deployment needs a restart every time the ECR token expires.During the evaluation, we saw that there are hooks into the Connaisseur deployment we will need in order to carry this out.We then revisited
auth.k8sKeychain
authentication mechanism again, hoping for better outcome this time around on Connaisseur application version 3.6.1 and chart version 2.6.1 knowing that this used to work in application version 3.0.0 and chart version 2.0.0 but somehow no matter what we do and follow the documentation, it doesn't work anymore.This time we decided to go all the way and read the code.
So we went through latest master codebase , golang file auth.go and we found what the issue is that is causing latest versions that need to use
auth.k8sKeychain
not to work anymore.At some point in the code, we changed from
auth.k8sKeychain
to 'auth.useKeychain.So now instead of setting
auth.k8sKeychain.truewe need to set 'auth.useKeychain.true
So there was one bug before in the code where the secret used by the keychain mechanism could not be created, that got fixed in mentioned PR.After this, still keychain mechanism was broken.This time the issue is not the code but we have a bug in our documentation.
Our latest documentation was never updated to reflect that the code no longer used
auth.k8sKeychain
but usesauth.useKeychain
Expected behavior
Optional: To reproduce
To reproduce, install Connaisseur application version 3.6.1 and chart version 2.6.1 on AWS EKS v1.30
Configure your validators section as shown below.
Observe that you get errors complaining that
This makes sense because from reading the code,
k8sKeychain
was changed touseKeychain
We will need to find out when the switch from
auth.k8sKeychain
toauth.useKeychain
was done as all those versions are affected.🚨 This looks like a critical omission in the documentation to synchronize the latest code implementation with the latest docs.
🙏 Could we please resolve (update documentation) as a matter of highest priority as this means everyone on the latest editions and trying to upgrade now has this capability broken !
Optional: Versions (please complete the following information as relevant):
Optional: Additional context
The text was updated successfully, but these errors were encountered: