Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aligning on file paths #75

Open
EdGreen21 opened this issue Jan 22, 2025 · 1 comment
Open

aligning on file paths #75

EdGreen21 opened this issue Jan 22, 2025 · 1 comment
Assignees

Comments

@EdGreen21
Copy link
Collaborator

looks like there's a misalignment between teams regarding the runner:

  1. WORKDIR being set to /apps, @KyleTCL using /scripts
  2. ENTRYPOINT ["conda", "run", "--no-capture-output", "-n", "predictcr", "predicTCR_runner"] @KyleTCL using script.sh
  3. DKFZ specific proxy settings now appear resolved on our side by editing /etc/docker/daemon.json rather than passing these env variables in the docker run command
@lkeegan
Copy link
Member

lkeegan commented Jan 22, 2025

looks like there's a misalignment between teams regarding the runner:

  1. WORKDIR being set to /apps, @KyleTCL using /scripts
  2. ENTRYPOINT ["conda", "run", "--no-capture-output", "-n", "predictcr", "predicTCR_runner"] @KyleTCL using script.sh

The WORKDIR and ENTRYPOINT of the docker image should not need to be modified, instead the PREDICTCR_RUNNER_SCRIPT_DIR environment variable should be set to point to the scripts folder, as described here: https://github.com/ssciwr/predicTCR/tree/main/runner#use

@KyleTCL let me know if this isn't working for you

  1. DKFZ specific proxy settings now appear resolved on our side by editing /etc/docker/daemon.json rather than passing these env variables in the docker run command

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants