add expired flag to MilestoneAnswerSession
#219
Labels
Comments
lkeegan
added a commit
that referenced
this issue
Feb 24, 2025
- refactor statistics calculation
- add `update_stats` function which updates milestones and milestone group statistics
- optional `update_existing_statistics` argument
- if `True`, then statistics updated using new answers as before
- if `False`, then recalculates all statistics using all answers (may be needed if e.g. some junk answers are deleted by an admin)
- reduce duplication
- `AnswerSession`
- add `expired` flag: initially False
- set to True by `get_or_create_current_milestone_answer_session` if it was created 7 or more days ago
- set to True when stats are updated if it was created 9 days or more ago
- includes a grace period to avoid setting a currently in use answer session to expired
- once an answer session is expired, then answers can no longer be modified / submitted by the user
- this should ensure that answers cannot be modified after they have been included in the statistics
- resolves #219
- add `included_in_statistics` flag: initially False
- set to True once the answers from this session are included in the statistics
- `MilestoneAnswer`
- remove `included_in_milestone_statistics` and `included_in_milestonegroup_statistics` flags
- this is now done at the level of an answer session rather than for each individual answer
- milestone feedback functions
- insert a `TrafficLight.invalid.value` instead of raising an exception if there are no statistics for a milestone id or group
- no longer recalculate stats when constructing feedback to avoid slowing down a user request in this case
- add `/update-milestone-age-scores` admin endpoint to recalculate the statistics
- TODO: add tests, add button(s) to admin interface?
- TODO: add scheduled calling of this function
lkeegan
added a commit
that referenced
this issue
Feb 28, 2025
- refactor statistics calculation
- add `update_stats` function which updates milestones and milestone group statistics
- optional `update_existing_statistics` argument
- if `True`, then statistics updated using new answers as before
- if `False`, then recalculates all statistics using all answers (may be needed if e.g. some junk answers are deleted by an admin)
- reduce duplication
- `AnswerSession`
- add `expired` flag: initially False
- set to True by `get_or_create_current_milestone_answer_session` if it was created 7 or more days ago
- set to True when stats are updated if it was created 9 days or more ago
- includes a grace period to avoid setting a currently in use answer session to expired
- once an answer session is expired, then answers can no longer be modified / submitted by the user
- this should ensure that answers cannot be modified after they have been included in the statistics
- resolves #219
- add `included_in_statistics` flag: initially False
- set to True once the answers from this session are included in the statistics
- `MilestoneAnswer`
- remove `included_in_milestone_statistics` and `included_in_milestonegroup_statistics` flags
- this is now done at the level of an answer session rather than for each individual answer
- milestone feedback functions
- insert a `TrafficLight.invalid.value` instead of raising an exception if there are no statistics for a milestone id or group
- no longer recalculate stats when constructing feedback to avoid slowing down a user request in this case
- add `/update-milestone-age-scores` admin endpoint to recalculate the statistics
- TODO: add tests, add button(s) to admin interface?
- TODO: add scheduled calling of this function
lkeegan
added a commit
that referenced
this issue
Feb 28, 2025
- refactor statistics calculation
- add `update_stats` function which updates milestones and milestone group statistics
- optional `incremental` argument
- if `True`, then statistics updated with any new answers since last calculation (as before)
- if `False`, then recalculates all statistics using all answers (may be needed if e.g. some junk answers are deleted by an admin)
- add apscheduler to schedule regular calls of this function (based on 271c75e)
- add `STATS_CRONTAB` to app settings to allow the schedule to be set, with a default crontab of 3am every monday
- add fastapi_injectable to allow use of fastapi dependencies outside of fastapi routes
- reduce duplication
- resolves #203
- `AnswerSession`
- add `expired` flag: initially False
- set to True by `get_or_create_current_milestone_answer_session` if it was created 7 or more days ago
- set to True when stats are updated if it was created 9 days or more ago
- includes a grace period to avoid setting a currently in use answer session to expired
- once an answer session is expired, then answers can no longer be modified / submitted by the user
- this should ensure that answers cannot be modified after they have been included in the statistics
- resolves #219
- add `included_in_statistics` flag: initially False
- set to True once the answers from this session are included in the statistics
- `MilestoneAnswer`
- remove `included_in_milestone_statistics` and `included_in_milestonegroup_statistics` flags
- this is now done at the level of an answer session rather than for each individual answer
- milestone feedback functions
- insert a `TrafficLight.invalid.value` instead of raising an exception if there are no statistics for a milestone id or group
- no longer recalculate stats when constructing feedback to avoid slowing down a user request in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #204
Currently:
get_current_milestone_answer_sessionchecks if the current session is expired, if so creates a new oneupdate_milestone_answeralways accepts an answer, i.e. doesn't check if answer session has expiredThis may lead to inconsistent/wrong stats, e.g. if an answer is changed after it was included in the stats.
Todo:
Add an
expiredflag toMilestoneAnswerSessionget_current_milestone_answer_sessionnow sets this expired flag if the current one is expiredupdate_milestone_answerstill always accepts answers (would be a poor user experience to reject an answer from a session that was valid when they started their current session if it expired while they were filling in the answers)expiredanswer sessions, no longer need to filter based on age of answer sessionThe text was updated successfully, but these errors were encountered: