From 6997be13d5c281174b8bbb92f30912cf8c09c114 Mon Sep 17 00:00:00 2001 From: Carl Montanari Date: Fri, 10 May 2024 14:48:10 -0700 Subject: [PATCH] chore: make config getter methods more clear wrt docker daemon/config mounts --- config/manager.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/config/manager.go b/config/manager.go index 60ed067..7260b19 100644 --- a/config/manager.go +++ b/config/manager.go @@ -133,9 +133,11 @@ type Manager interface { GetImagePullCriSockOverride() string // GetImagePullCriKindOverride returns the cri kind override. GetImagePullCriKindOverride() string - // GetDockerDaemonConfig returns the secret name to mount in /etc/docker. + // GetDockerDaemonConfig returns the secret name to mount in /etc/docker -- the secret *must* + // have a key "daemon.json" so the final mounted file is /etc/docker/daemon.json. GetDockerDaemonConfig() string - // GetDockerConfig returns the secret name to mount in /root/.docker/. + // GetDockerConfig returns the secret name to mount in /root/.docker/ -- the secret *must* have + // a key "config.json" so the final mounted file is /root/.docker/config.json. GetDockerConfig() string // GetLauncherImage returns the global default launcher image. GetLauncherImage() string