Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL Lab] When buttons don't fit on toolbar it's not possible to resize the text-editor #222

Open
se7entyse7en opened this issue Jul 23, 2019 · 4 comments
Open

[SQL Lab] When buttons don't fit on toolbar it's not possible to resize the text-editor #222

se7entyse7en opened this issue Jul 23, 2019 · 4 comments
Labels
blocked This is blocked for some reason bug Something isn't working product-design Visual, branding, typography

Comments

@se7entyse7en
Copy link
Contributor

On my screen (MB Pro 13") when I run a query and the LIMIT 1000 button appears, it's not placed in the same line of the other buttons, but on a new line. This makes the text-editor size adjustment dragger unusable.

Screenshot after query run:

Screenshot 2019-07-23 at 14 13 57

The current workaround is to reduce the zoom from the browser's settings.
@se7entyse7en se7entyse7en added the bug Something isn't working label Jul 23, 2019
@smacker
Copy link
Contributor

smacker commented Jul 23, 2019

another workaround is to disable "Allow CREATE TABLE AS". Then everything would fit.

@dpordomingo
Copy link
Contributor

why am I not seeing that input? when was it added?
(I'm using the tip of sourced v0.14.0-rc.1 with builtin sourced-ui:v0.4.0-rc.2)

why not making the "save" button smarter, so you could choose either saving the query, or the table?
I'm just wondering that because the current layout is not flexible enough to let us adding there whatever content :(

@se7entyse7en se7entyse7en added the product-design Visual, branding, typography label Oct 18, 2019
@smacker
Copy link
Contributor

smacker commented Oct 22, 2019

@dpordomingo it was also there. The switcher is mentioned in the comment above.

@rpau
Copy link

rpau commented Oct 23, 2019

@ricardobaeta your help is needed here.

@rpau rpau added the blocked This is blocked for some reason label Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This is blocked for some reason bug Something isn't working product-design Visual, branding, typography
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smacker @rpau @dpordomingo @se7entyse7en