Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the .SouthPane @ SQL Lab work with CSS dimentions #218

Open
dpordomingo opened this issue Jul 18, 2019 · 2 comments
Open

Make the .SouthPane @ SQL Lab work with CSS dimentions #218

dpordomingo opened this issue Jul 18, 2019 · 2 comments
Labels
enhancement New feature or request needs more info Further information from author of issue is requested

Comments

@dpordomingo
Copy link
Contributor

caused by #210

Superset calculates the height of the .SouthPane and the filtered table @ SQL Lab with javascript, using hardcoded heights for tabs and buttons so what causes problems as described by #210 and #184.

It was locally fixed by #210, but as suggested by #210 (comment), it could be contributed upstream.
@dpordomingo dpordomingo added the enhancement New feature or request label Jul 18, 2019
@se7entyse7en
Copy link
Contributor

@dpordomingo do you perhaps know the status of this? Since this was opened we updated superset, so maybe this is not relevant anymore? We should recheck this. In the meantime, I'm moving this back to backlog.

@se7entyse7en se7entyse7en added the needs more info Further information from author of issue is requested label Oct 18, 2019
@dpordomingo
Copy link
Contributor Author

If I'm not wrong, they're still calculating the sizes with hardcoded dimensions:
incubator-superset/superset/assets/src/SqlLab/components/SouthPane.jsx

I'll maybe consider contributing to upstream during next osd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs more info Further information from author of issue is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpordomingo @se7entyse7en