Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fail -- requirements are invalid #23

Open
remram44 opened this issue Dec 17, 2021 · 5 comments
Open

Installation fail -- requirements are invalid #23

remram44 opened this issue Dec 17, 2021 · 5 comments

Comments

@remram44
Copy link

remram44 commented Dec 17, 2021

The current setup.py lists:

    install_requires=["numpy>=1.0.0"],
    tests_require=["scipy>=1.0.0"],
    setup_requires=["numpy>=1.20.0"],

This means pip will try to install the current version on lapjv even if numpy is older than 1.20. It will build against numpy 1.20, install it in your environment with older numpy, and import lapjv will fail with:

RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: numpy.core.multiarray failed to import

Please sync install_requires with setup_requires as building with one version and running with another does NOT work.

@remram44
Copy link
Author

remram44 commented Dec 17, 2021

It appears this has already been fixed by 32c7108 in 1.3.14 but pip will just grab 1.3.13 because it will think that version is compatible with any numpy. Maybe 1.3.13 should be yanked? That would help a lot with those of us using numpy<1.20.

@vmarkovtsev
Copy link
Collaborator

This is the problem that I caught in my own production today, let's fix this.

@vmarkovtsev
Copy link
Collaborator

NP with yanking 1.3.13, but won't the story repeat with 1.3.12, 1.3.11, etc.?

@remram44
Copy link
Author

I don't think so, the problem was introduce by #21 right before 1.3.13. Previous versions used build requirement numpy>=1.0.0 and install requirement numpy>=1.0.0, so they matched.

@remram44
Copy link
Author

remram44 commented Jul 8, 2022

The metadata is out of sync again, setup.py says install_requires=["numpy>=1.20.0"] and pyproject.toml says requires = ["numpy>=1.21.0"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants