Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Add ModalContainer to Samples #786

Closed
3 tasks done
JustinDSN opened this issue Nov 27, 2019 · 1 comment
Closed
3 tasks done

[Swift] Add ModalContainer to Samples #786

JustinDSN opened this issue Nov 27, 2019 · 1 comment
Assignees
Labels
swift Affects the Swift library.
Milestone

Comments

@JustinDSN
Copy link
Contributor

JustinDSN commented Nov 27, 2019

Swift samples don't provide guidance on how to display .fullScreen modals in Workflows.

This ticket is to address one of comments of square/workflow-swift#143, and pave the way to creating a proving grounds for and modals and perhaps alerts and maybe even cards. But first things first!

@bencochran Tells me Swift's modal container isn't even in github yet – but this will be something we need to ensure is addressed when that day comes.

We can extract our internal version of WorkflowModalContainer and remove all unnecessary private bits.

Checklist:

  • Extract WorkflowModalContainer into swift/Samples/ModalContainer
  • Make a podspec for this new sample (as it can be used in other samples just like BackStackContainer in swift/Samples/BackStackContainer)
  • Create or extend an existing sample to consume this new pod.
@JustinDSN JustinDSN added the swift Affects the Swift library. label Feb 27, 2020
@JustinDSN JustinDSN added this to the v1.0.0 milestone Mar 3, 2020
@JustinDSN
Copy link
Contributor Author

Resolved by #1090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift Affects the Swift library.
Projects
None yet
Development

No branches or pull requests

2 participants