Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workflow internal behavior into interceptor APIs #1235

Open
pyricau opened this issue Nov 20, 2024 · 1 comment
Open

Make workflow internal behavior into interceptor APIs #1235

pyricau opened this issue Nov 20, 2024 · 1 comment

Comments

@pyricau
Copy link
Member

pyricau commented Nov 20, 2024

Check our internal ActionLogger and WorkflowSystemTracer and create APIs so that those implementations are straightforward and show 0 knowledge of workflow internals.

Some examples:

  • to get access to actions you need to wrap a render then wrap actions + wrap render child + wrap actions (all you want is "an API for knowing about actions")
  • relying on "session.parent = null" for root
  • tracking of the map of workflow names
  • the fact that we are mirroring the skipping logic to figure out if workflow will skip a render
@steve-the-edwards
Copy link
Contributor

I think this likely looks like a WorkflowTracer API that includes these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants