New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`ComponentDialog.asDialogHolderWithContent` should provide decor view as container #1097

Open

rjrjr opened this issue Aug 3, 2023 · 0 comments

Contributor

rjrjr commented Aug 3, 2023 •

edited

Loading

This:

    .buildView(overlay.content, envWithOnBack, context)

should be this:

    .buildView(overlay.content, envWithOnBack, context, decorView as ViewGroup)

But watch out for the perils of resolving decorView too early I hate Android. (Note use of our Dialog.decorView extension.)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment