Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentStreamRequestHandler and Crashing Remote Process #2339

Open
herriojr opened this issue Nov 8, 2022 · 0 comments
Open

ContentStreamRequestHandler and Crashing Remote Process #2339

herriojr opened this issue Nov 8, 2022 · 0 comments

Comments

@herriojr
Copy link

herriojr commented Nov 8, 2022 •
edited
Loading

It appears when using contentResolver.openInputStream(uri), if it is a content:// uri, it will under the hood call ContentResolver.openTypedAssetFileDescriptor. Internal to here, the problem is that if the remote process died while trying to make the call, it falls back to making a call to the stable provider. If the stable provider dies mid call, it will kill the process making the query. The ContentStreamRequestHandler should be rewritten to reimplement the ContentResolver.openInputStream() using only the Unstable ContentProviderClient.
herriojr added a commit to herriojr/picasso that referenced this issue Nov 8, 2022
@herriojr
Ensure openInputStream cannot kill calling process
ac2c44a 
This addresses issue square#2339

ContentResolver.openInputStream falls back to using a stable content
provider which will kill the main process if it fails. Never trust an
external process as there may be many things that might cause this such
as reinstalls, application updates, etc. Fall back to a
FileNotFoundException.
@herriojr herriojr mentioned this issue Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@herriojr