Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node animation does not work as expected #12

Open
akambale opened this issue Mar 9, 2022 · 0 comments
Open

Node animation does not work as expected #12

akambale opened this issue Mar 9, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@akambale
Copy link
Collaborator

akambale commented Mar 9, 2022

Describe the bug
In the collapsible tidy tree diagram that was used as reference code, nodes in the tree fade in and out and the circles shrink and grow. I was unable to copy this functionality in this library.

If any D3 experts are interested in taking a crack at debugging this your help is much appreciated!

To Reproduce
See the live playground. Click on the tree nodes.
See the example from d3noob. This tree animates correctly.

See the update code where this style changing code is supposed to be working.

Additional context
I wonder if part of the issue is that this library passes a graph into d3.hierarchy, which is not the expected input. Because these data objects are referenced and referenced as we set multiple trees, are the D3 coordinate objects persisted in memory? And thus, the previous r and fill-opacity values are preserved. This is only a hunch.

@akambale akambale added the bug Something isn't working label Mar 9, 2022
@akambale akambale changed the title Node Animation does not work as expected Node animation does not work as expected Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant