-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build without greedy uncaughtException handler #262
Comments
Oh wow! I just read about this behavior and came across this Emscripten issue: emscripten-core/emscripten#2629 That's where the code originally got added. I've been reading about this, and my current thought is that if we were compiling an executable, it would be appropriate to have this global exception handling added so that Emscripten can manage exiting from the process, as it apparently wants to do. However, for a library like Sql.js, it feels inappropriate to me to handle global exceptions simply by including the library in your Node app. So, I agree and will fix this in #255. We'll see what the maintainers think. |
Fixes kripken/sql.js/sql-js#173 Fixes kripken/sql.js/sql-js#262
I agree we should not handle global exceptions |
This is related to #173.
I wrote up what is happening here: https://github.com/danielbarela/sqljs-uncaughtexception
This issue in emscripten indicates that the library can be built without the greedy exception handler:
emscripten-core/emscripten#5957
Can this option be added to the sql.js build and republished?
The text was updated successfully, but these errors were encountered: