Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmHeatmap: node stack overflow #12

Open
f6v opened this issue Oct 11, 2020 · 5 comments
Open

lmHeatmap: node stack overflow #12

f6v opened this issue Oct 11, 2020 · 5 comments

Comments

@f6v
Copy link

f6v commented Oct 11, 2020

I'm trying to run the example with the simulated data, and I've got a failure on the following line:

lmHeatmap(scAI_outs, color.by = "labels")

Error in is.leaf(dend) : node stack overflow
Error during wrapup: node stack overflow
Error: no more error handlers available (recursive errors?); invoking 'abort' restart

Quick search led me to trying the following: options(expression = 1000000), though the result was the same. Have you seen this issue before?

I'm running R 4.0.2 on macOS.

Thanks in advance!

@sqjin
Copy link
Owner

sqjin commented Oct 12, 2020

Hi @f6v , I am sorry that I have not encounter such issue before. I have not upgraded my R version to 4.0. There might be some conflicts with R version or the ComplexHeatmap package.

@f6v
Copy link
Author

f6v commented Oct 12, 2020

Thanks, I guess the issue arises from jokergoo/ComplexHeatmap#539

@jokergoo
Copy link

Yes, that was a bug in ComplexHeatmap and a little difficult to fix. Can you add tiny noise to the matrix e.g.

scAI_outs = scAI_outs + runif(length(scAI_outs), min = -0.5, max = 0.5)*1e-5

@sqjin
Copy link
Owner

sqjin commented Oct 20, 2020

Thanks @jokergoo !! I just added a tiny noise to the matrix @f6v

@jokergoo
Copy link

Hi, I think I have fixed this bug. The problem was when there are too many identical rows or columns, the dendrogram will be very deep, which causes the recursive function which was used in ComplexHeatmap to generate too many stack calls. Now I have changed the recursive implementation with iterations and I think there should be no such error any more.

You can just update the version from Github if you want to use it now. I will do more testing and then I will push to bioconductor in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants