Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a default fallback icon to show in case a entry for a font is removed after a font update #175

Open
dalthviz opened this issue Oct 19, 2021 · 2 comments

Comments

@dalthviz
Copy link
Member

dalthviz commented Oct 19, 2021

After font updates the respective *-charmap.json can have missing entries previously available. In case of complete removal of an icon from the font, QtAwesome should not throw an exception with a Invalid icon name "x" in font "y" message but show a default icon

@dalthviz dalthviz added this to the v1.1.0 milestone Oct 19, 2021
@ccordoba12
Copy link
Member

Well, I think you need to select a fallback icon in the font itself and add the corresponding entries to the font's charmap.json.

@dalthviz
Copy link
Member Author

I was thinking in a default icon for any icon set but I guess we could add a predefined name for the default icon to be added in the corresponding *-charmap.json (something like qta-default or something like that). Although if the addition in the charmap is forgotten then we should have a default icon or the exception should be still be thrown?

Maybe we should have a fallback chain like icon from the set > defined default icon from set > default qtawesome icon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants