Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert required types in vc::syntax::Types::default. #579

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Insert required types in vc::syntax::Types::default. #579

merged 1 commit into from
Jul 12, 2024

Conversation

timothee-haudebourg
Copy link
Contributor

@timothee-haudebourg timothee-haudebourg commented Jul 12, 2024 •
edited
Loading

The current Default implementation for vc::syntax::Types does not add all the statically required types. This fixes it.

@sbihel
Copy link
Member

sbihel commented Jul 12, 2024

I just deleted the cache because I feel like it was full of old stuff. I would recommend using the ubuntu-latest-m runner for test-each-feature, it should speed things up

@timothee-haudebourg timothee-haudebourg merged commit 3f2b1d3 into main Jul 12, 2024
4 checks passed
@timothee-haudebourg timothee-haudebourg deleted the fix-default-vc-required-types branch July 12, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothee-haudebourg @sbihel