Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Ed25519 compatibility #439

Open
clehner opened this issue May 24, 2022 · 1 comment
Open

Test Ed25519 compatibility #439

clehner opened this issue May 24, 2022 · 1 comment

Comments

@clehner
Copy link
Contributor

clehner commented May 24, 2022

A verification error was observed in verification compatibility between the ring Ed25519 and ed25519-dalek implementations. This issue is to track how this is happening and adding tests to ensure compatibility between the Ed25519 implementations.

@clehner
Copy link
Contributor Author

clehner commented May 24, 2022

The reported error was apparently due to something other than the signature verification. So we assume there is no incompatibility. But the tests should probably be improved anyway to catch any potential incompatibility.
This issue can remain to track testing signing with one of the ed25519 implementation and verifying with the other.
Currently ssi can only be compiled with one implementation or the other. Existing test vectors were generated using the ring implementation, I think. Possibly an example script or Rust build script could be run in the CI with each implementation to generate test vectors, and then again to verify each test vector with each implementation.

@clehner clehner changed the title Possible Ed25519 incompatibility Test Ed25519 compatibility May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant