From 4f4e50f24fcc61b352fb550ef0da6032cbf56e3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Haudebourg?= Date: Mon, 16 Sep 2024 12:39:15 +0200 Subject: [PATCH] Passing tests. --- crates/claims/crates/jws/src/compact/bytes.rs | 2 +- .../claims/crates/jws/src/compact/url_safe.rs | 31 ++-- crates/claims/crates/jws/src/lib.rs | 2 +- crates/claims/crates/jws/src/verification.rs | 5 + crates/claims/crates/sd-jwt/src/conceal.rs | 5 +- crates/claims/crates/sd-jwt/src/disclosure.rs | 20 +- crates/claims/crates/sd-jwt/src/lib.rs | 2 +- crates/claims/crates/sd-jwt/src/reveal.rs | 95 ++++++---- crates/claims/crates/sd-jwt/tests/decode.rs | 58 +++++- .../crates/sd-jwt/tests/rfc_examples.rs | 171 +++++++++++++----- 10 files changed, 261 insertions(+), 130 deletions(-) diff --git a/crates/claims/crates/jws/src/compact/bytes.rs b/crates/claims/crates/jws/src/compact/bytes.rs index c99227b0e..734f289f3 100644 --- a/crates/claims/crates/jws/src/compact/bytes.rs +++ b/crates/claims/crates/jws/src/compact/bytes.rs @@ -225,7 +225,7 @@ impl CompactJWSBuf { ) -> Result>> { let mut bytes = signing_bytes; bytes.push(b'.'); - bytes.extend(signature.iter().copied()); + bytes.extend_from_slice(signature); Self::new(bytes) } diff --git a/crates/claims/crates/jws/src/compact/url_safe.rs b/crates/claims/crates/jws/src/compact/url_safe.rs index f7ae95bc9..a8ea65fc2 100644 --- a/crates/claims/crates/jws/src/compact/url_safe.rs +++ b/crates/claims/crates/jws/src/compact/url_safe.rs @@ -1,5 +1,6 @@ use base64::Engine; use core::fmt; +use ssi_core::BytesBuf; use std::{ops::Deref, str::FromStr}; use crate::{ @@ -201,24 +202,14 @@ impl<'a> PartialEq<&'a UrlSafeJws> for String { pub struct UrlSafeJwsBuf(String); impl UrlSafeJwsBuf { - pub fn new(bytes: Vec) -> Result>> { - match String::from_utf8(bytes) { - Ok(string) => { - if CompactJWS::validate(string.as_bytes()) { - Ok(Self(string)) - } else { - Err(InvalidCompactJWS(string.into_bytes())) - } - } - Err(e) => Err(InvalidCompactJWS(e.into_bytes())), - } - } - - pub fn from_string(string: String) -> Result> { - if CompactJWS::validate(string.as_bytes()) { - Ok(Self(string)) + pub fn new(bytes: B) -> Result> { + if UrlSafeJws::validate(bytes.as_ref()) { + Ok(unsafe { + // SAFETY: we just validated the bytes. + Self::new_unchecked(bytes.into()) + }) } else { - Err(InvalidCompactJWS(string)) + Err(InvalidCompactJWS(bytes)) } } @@ -331,7 +322,7 @@ impl FromStr for UrlSafeJwsBuf { type Err = InvalidCompactJWS; fn from_str(s: &str) -> Result { - Self::from_string(s.to_owned()) + Self::new(s.to_owned()) } } @@ -339,7 +330,7 @@ impl TryFrom for UrlSafeJwsBuf { type Error = InvalidCompactJWS; fn try_from(value: String) -> Result { - Self::from_string(value) + Self::new(value) } } @@ -368,7 +359,7 @@ impl<'de> serde::Deserialize<'de> for UrlSafeJwsBuf { where E: serde::de::Error, { - UrlSafeJwsBuf::from_string(v).map_err(|e| E::custom(e)) + UrlSafeJwsBuf::new(v).map_err(|e| E::custom(e)) } } diff --git a/crates/claims/crates/jws/src/lib.rs b/crates/claims/crates/jws/src/lib.rs index 61f9ca616..29a918d75 100644 --- a/crates/claims/crates/jws/src/lib.rs +++ b/crates/claims/crates/jws/src/lib.rs @@ -196,7 +196,7 @@ impl<'a, T> DecodedJWS<'a, T> { pub fn into_encoded(self) -> CompactJWSBuf { CompactJWSBuf::from_signing_bytes_and_signature( self.signing_bytes.bytes.into_owned(), - &self.signature, + self.signature.encode().as_bytes(), ) .unwrap() } diff --git a/crates/claims/crates/jws/src/verification.rs b/crates/claims/crates/jws/src/verification.rs index 92a27826b..3e8957c18 100644 --- a/crates/claims/crates/jws/src/verification.rs +++ b/crates/claims/crates/jws/src/verification.rs @@ -1,4 +1,5 @@ use crate::{verify_bytes, DecodedJWS, DecodedSigningBytes, Error, Header}; +use base64::{engine::general_purpose::URL_SAFE_NO_PAD, Engine}; use ssi_claims_core::{ ClaimsValidity, InvalidProof, ProofValidationError, ProofValidity, ResolverProvider, ValidateClaims, ValidateProof, VerifiableClaims, @@ -47,6 +48,10 @@ impl JWSSignature { pub fn into_bytes(self) -> Vec { self.0 } + + pub fn encode(&self) -> String { + URL_SAFE_NO_PAD.encode(&self.0) + } } impl From> for JWSSignature { diff --git a/crates/claims/crates/sd-jwt/src/conceal.rs b/crates/claims/crates/sd-jwt/src/conceal.rs index ad6a8dbb0..072ca1080 100644 --- a/crates/claims/crates/sd-jwt/src/conceal.rs +++ b/crates/claims/crates/sd-jwt/src/conceal.rs @@ -148,7 +148,10 @@ impl SdJwtPayload { ) -> Result<(Self, Vec>), ConcealError> { let mut disclosures = Vec::new(); - for pointer in pointers { + let mut sorted_pointers: Vec<_> = pointers.iter().map(Borrow::borrow).collect(); + sorted_pointers.sort_unstable(); + + for pointer in pointers.into_iter().rev() { disclosures.push(conceal_object_at( &mut claims, &mut rng, diff --git a/crates/claims/crates/sd-jwt/src/disclosure.rs b/crates/claims/crates/sd-jwt/src/disclosure.rs index 84c2763ca..45206eb89 100644 --- a/crates/claims/crates/sd-jwt/src/disclosure.rs +++ b/crates/claims/crates/sd-jwt/src/disclosure.rs @@ -129,11 +129,10 @@ pub struct DisclosureBuf(Vec); impl DisclosureBuf { /// Creates a disclosure from its defining parts. pub fn encode_from_parts(salt: &str, kind: &DisclosureDescription) -> Self { - Self( - BASE64_URL_SAFE_NO_PAD - .encode(kind.to_value(salt).to_string()) - .into_bytes(), - ) + let string = kind.to_value(salt).to_string(); + // eprintln!("value = {string}"); + + Self(BASE64_URL_SAFE_NO_PAD.encode(string).into_bytes()) } /// Borrows the disclosure. @@ -232,6 +231,15 @@ impl<'a> DecodedDisclosure<'a> { desc: kind, } } + + /// Clones the encoded disclosure to fully owned the decoded disclosure. + pub fn into_owned(self) -> DecodedDisclosure<'static> { + DecodedDisclosure { + encoded: Cow::Owned(self.encoded.into_owned()), + salt: self.salt, + desc: self.desc, + } + } } /// Disclosure description. @@ -383,7 +391,7 @@ mod tests { "nPuoQnkRFq3BIeAm7AnXFA".to_owned(), DisclosureDescription::ArrayItem(serde_json::json!("DE")) ), - DecodedDisclosure::new("WyJuUHVvUW5rUkZxM0JJZUFtN0FuWEZBIiwgIkRFIl0").unwrap() + DecodedDisclosure::new("WyJuUHVvUW5rUkZxM0JJZUFtN0FuWEZBIiwiREUiXQ").unwrap() ) } } diff --git a/crates/claims/crates/sd-jwt/src/lib.rs b/crates/claims/crates/sd-jwt/src/lib.rs index 8de3b2c3a..67175fe62 100644 --- a/crates/claims/crates/sd-jwt/src/lib.rs +++ b/crates/claims/crates/sd-jwt/src/lib.rs @@ -382,7 +382,7 @@ impl<'a> Iterator for Disclosures<'a> { fn next(&mut self) -> Option { let mut i = self.offset; - while i < self.offset { + while i < self.bytes.len() { if self.bytes[i] == b'~' { let disclosure = unsafe { // SAFETY: we already validated the SD-JWT and know diff --git a/crates/claims/crates/sd-jwt/src/reveal.rs b/crates/claims/crates/sd-jwt/src/reveal.rs index 58ba13ebf..c344f7b9c 100644 --- a/crates/claims/crates/sd-jwt/src/reveal.rs +++ b/crates/claims/crates/sd-jwt/src/reveal.rs @@ -20,8 +20,8 @@ pub enum RevealError { Decode(#[from] DecodeError), /// Unused disclosure. - #[error("unused disclosure")] - UnusedDisclosure, + #[error("unused disclosure `{0:?}`")] + UnusedDisclosure(DecodedDisclosure<'static>), /// Claim collision. #[error("claim collision")] @@ -79,6 +79,9 @@ impl SdJwtPayload { disclosures: &[DecodedDisclosure], pointers: &mut Vec, ) -> Result, RevealError> { + eprintln!("payload: {}", serde_json::to_string_pretty(self).unwrap()); + eprintln!("disclosures: {disclosures:#?}"); + let mut disclosures: IndexMap<_, _> = disclosures .iter() .map(|disclosure| { @@ -87,17 +90,17 @@ impl SdJwtPayload { }) .collect(); - let mut disclosed_claims = serde_json::Map::new(); - for (key, value) in &self.claims { - let mut pointer = JsonPointerBuf::default(); - pointer.push(key); - let mut value = value.clone(); - reveal_value(&pointer, &mut value, &mut disclosures)?; - disclosed_claims.insert(key.clone(), value); - } + let mut disclosed_claims = self.claims.clone(); + reveal_object( + &JsonPointerBuf::default(), + &mut disclosed_claims, + &mut disclosures, + )?; for (_, disclosure) in disclosures { - pointers.push(disclosure.pointer.ok_or(RevealError::UnusedDisclosure)?); + pointers.push(disclosure.pointer.ok_or_else(|| { + RevealError::UnusedDisclosure(disclosure.disclosure.clone().into_owned()) + })?); } serde_json::from_value(Value::Object(disclosed_claims)).map_err(Into::into) @@ -127,25 +130,7 @@ fn reveal_value( disclosures: &mut IndexMap, ) -> Result<(), RevealError> { match value { - Value::Object(object) => { - // Process `_sd` claim. - if let Some(sd_claims) = object.remove(SD_CLAIM_NAME) { - for (key, value) in reveal_sd_claim(pointer, &sd_claims, disclosures)? { - if object.insert(key, value).is_some() { - return Err(RevealError::Collision); - } - } - } - - // Visit sub-values. - for (key, sub_value) in object { - let mut pointer = pointer.to_owned(); - pointer.push(key); - reveal_value(&pointer, sub_value, disclosures)? - } - - Ok(()) - } + Value::Object(object) => reveal_object(pointer, object, disclosures), Value::Array(array) => array.try_retain_mut(|i, item| { let mut pointer = pointer.to_owned(); pointer.push_index(i); @@ -154,11 +139,16 @@ fn reveal_value( Some(hash) => match disclosures.get_mut(hash) { Some(in_progress_disclosure) => match &in_progress_disclosure.disclosure.desc { DisclosureDescription::ArrayItem(value) => { - if in_progress_disclosure.pointer.replace(pointer).is_some() { + if in_progress_disclosure + .pointer + .replace(pointer.clone()) + .is_some() + { return Err(RevealError::DisclosureUsedMultipleTimes); } *item = value.clone(); + reveal_value(&pointer, item, disclosures)?; Ok(true) } DisclosureDescription::ObjectEntry { .. } => { @@ -177,6 +167,30 @@ fn reveal_value( } } +fn reveal_object( + pointer: &JsonPointer, + object: &mut serde_json::Map, + disclosures: &mut IndexMap, +) -> Result<(), RevealError> { + // Process `_sd` claim. + if let Some(sd_claims) = object.remove(SD_CLAIM_NAME) { + for (key, value) in reveal_sd_claim(pointer, &sd_claims, disclosures)? { + if object.insert(key, value).is_some() { + return Err(RevealError::Collision); + } + } + } + + // Visit sub-values. + for (key, sub_value) in object { + let mut pointer = pointer.to_owned(); + pointer.push(key); + reveal_value(&pointer, sub_value, disclosures)? + } + + Ok(()) +} + fn reveal_sd_claim( pointer: &JsonPointer, sd_claim: &serde_json::Value, @@ -261,25 +275,26 @@ mod tests { "iss": "https://example.com/issuer", "iat": 1683000000, "exp": 1883000000, - "sub": "6c5c0a49-b589-431d-bae7-219122a9ec2c", - "given_name": "太郎", - "family_name": "山田", - "email": "\"unusual email address\"@example.jp", - "phone_number": "+81-80-1234-5678", + // "sub": "6c5c0a49-b589-431d-bae7-219122a9ec2c", + // "given_name": "太郎", + // "family_name": "山田", + // "email": "\"unusual email address\"@example.jp", + // "phone_number": "+81-80-1234-5678", "address": { - "street_address": "東京都港区芝公園４丁目２−８", - "locality": "東京都", + // "street_address": "東京都港区芝公園４丁目２−８", + // "locality": "東京都", "region": "港区", "country": "JP" }, - "birthdate": "1940-01-01" + // "birthdate": "1940-01-01" }) }); #[test] fn disclose() { let sd_jwt = SdJwt::new(SD_JWT).unwrap(); - let disclosed = sd_jwt.decode().unwrap().reveal_any().unwrap(); + let decoded = sd_jwt.decode().unwrap(); + let disclosed = decoded.reveal_any().unwrap(); let output = serde_json::to_value(disclosed.claims()).unwrap(); assert_eq!(output, *DISCLOSED_CLAIMS) } diff --git a/crates/claims/crates/sd-jwt/tests/decode.rs b/crates/claims/crates/sd-jwt/tests/decode.rs index add8dd3ec..150432778 100644 --- a/crates/claims/crates/sd-jwt/tests/decode.rs +++ b/crates/claims/crates/sd-jwt/tests/decode.rs @@ -9,22 +9,46 @@ use ssi_sd_jwt::{disclosure, Disclosure, PartsRef}; #[derive(Debug, Default, Deserialize, Serialize, PartialEq)] struct ExampleClaims { + #[serde(skip_serializing_if = "Option::is_none")] given_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] family_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] email: Option, + + #[serde(skip_serializing_if = "Option::is_none")] phone_number: Option, + + #[serde(skip_serializing_if = "Option::is_none")] phone_number_verified: Option, + + #[serde(skip_serializing_if = "Option::is_none")] address: Option, + + #[serde(skip_serializing_if = "Option::is_none")] birthdate: Option, + + #[serde(skip_serializing_if = "Option::is_none")] updated_at: Option, + + #[serde(skip_serializing_if = "Option::is_none")] nationalities: Option>, } #[derive(Debug, Default, Deserialize, Serialize, PartialEq)] struct AddressClaim { + #[serde(skip_serializing_if = "Option::is_none")] street_address: Option, + + #[serde(skip_serializing_if = "Option::is_none")] locality: Option, + + #[serde(skip_serializing_if = "Option::is_none")] region: Option, + + #[serde(skip_serializing_if = "Option::is_none")] country: Option, } @@ -97,17 +121,28 @@ async fn disclose_single() { let disclosed = sd_jwt.decode().unwrap().reveal::().unwrap(); - assert_eq!( - disclosed.into_claims(), - JWTClaims::builder() - .sub("user_42") - .with_private_claims(ExampleClaims { - email: Some("johndoe@example.com".to_owned()), - nationalities: Some(vec![]), - ..Default::default() - }) - .unwrap() + let expected = JWTClaims::builder() + .iss("https://example.com/issuer") + .iat(1683000000) + .exp(1883000000) + .sub("user_42") + .with_private_claims(ExampleClaims { + email: Some("johndoe@example.com".to_owned()), + nationalities: Some(vec![]), + ..Default::default() + }) + .unwrap(); + + eprintln!( + "found = {}", + serde_json::to_string_pretty(disclosed.claims()).unwrap() ); + eprintln!( + "expected = {}", + serde_json::to_string_pretty(&expected).unwrap() + ); + + assert_eq!(disclosed.into_claims(), expected); } #[async_std::test] @@ -121,6 +156,9 @@ async fn decode_single_array_item() { assert_eq!( disclosed.into_claims(), JWTClaims::builder() + .iss("https://example.com/issuer") + .iat(1683000000) + .exp(1883000000) .sub("user_42") .with_private_claims(ExampleClaims { nationalities: Some(vec!["DE".to_owned()]), diff --git a/crates/claims/crates/sd-jwt/tests/rfc_examples.rs b/crates/claims/crates/sd-jwt/tests/rfc_examples.rs index e62e7474d..c23d90c32 100644 --- a/crates/claims/crates/sd-jwt/tests/rfc_examples.rs +++ b/crates/claims/crates/sd-jwt/tests/rfc_examples.rs @@ -24,19 +24,36 @@ static JWK: LazyLock = LazyLock::new(|| { async fn rfc_a_1_example_2_verification() { #[derive(Debug, Default, Clone, Serialize, Deserialize, PartialEq)] struct Example2Address { + #[serde(skip_serializing_if = "Option::is_none")] street_address: Option, + + #[serde(skip_serializing_if = "Option::is_none")] locality: Option, + + #[serde(skip_serializing_if = "Option::is_none")] region: Option, + + #[serde(skip_serializing_if = "Option::is_none")] country: Option, } #[derive(Debug, Default, Clone, Serialize, Deserialize, PartialEq)] struct Example2Claims { + #[serde(skip_serializing_if = "Option::is_none")] given_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] family_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] email: Option, + + #[serde(skip_serializing_if = "Option::is_none")] phone_number: Option, - address: Option, + + address: Example2Address, + + #[serde(skip_serializing_if = "Option::is_none")] birthdate: Option, } @@ -92,44 +109,62 @@ async fn rfc_a_1_example_2_verification() { .unwrap(); assert_eq!(verification, Ok(())); - assert_eq!( - *revealed.claims(), - JWTClaims::builder() - .sub("6c5c0a49-b589-431d-bae7-219122a9ec2c") - .iss("https://example.com/issuer") - .iat(1683000000) - .exp(1883000000) - .with_private_claims(Example2Claims { - given_name: Some("太郎".to_owned()), - family_name: Some("山田".to_owned()), - email: Some("\"unusual email address\"@example.jp".to_owned()), - phone_number: Some("+81-80-1234-5678".to_owned()), - address: Some(Example2Address { - street_address: Some("東京都港区芝公園４丁目２−８".to_owned()), - locality: Some("東京都".to_owned()), - region: Some("港区".to_owned()), - country: Some("JP".to_owned()), - }), - birthdate: Some("1940-01-01".to_owned()) - }) - .unwrap() + + let expected = JWTClaims::builder() + .sub("6c5c0a49-b589-431d-bae7-219122a9ec2c") + .iss("https://issuer.example.com") + .iat(1683000000) + .exp(1883000000) + .with_private_claims(Example2Claims { + given_name: Some("太郎".to_owned()), + family_name: Some("山田".to_owned()), + email: Some("\"unusual email address\"@example.jp".to_owned()), + phone_number: Some("+81-80-1234-5678".to_owned()), + address: Example2Address { + street_address: Some("東京都港区芝公園４丁目２−８".to_owned()), + locality: Some("東京都".to_owned()), + region: Some("港区".to_owned()), + country: Some("JP".to_owned()), + }, + birthdate: Some("1940-01-01".to_owned()), + }) + .unwrap(); + + eprintln!( + "expected = {}", + serde_json::to_string_pretty(&expected).unwrap() ); + eprintln!( + "found = {}", + serde_json::to_string_pretty(revealed.claims()).unwrap() + ); + + assert_eq!(*revealed.claims(), expected); let empty_sd_jwt = revealed.clone().cleared().into_encoded(); let (empty_revealed, verification) = empty_sd_jwt.decode_reveal_verify(¶ms).await.unwrap(); assert_eq!(verification, Ok(())); - assert_eq!( - *empty_revealed.claims(), - JWTClaims::builder() - .iss("https://example.com/issuer") - .iat(1683000000) - .exp(1883000000) - .with_private_claims(Example2Claims::default()) - .unwrap() + + let expected = JWTClaims::builder() + .iss("https://issuer.example.com") + .iat(1683000000) + .exp(1883000000) + .with_private_claims(Example2Claims::default()) + .unwrap(); + + eprintln!( + "expected = {}", + serde_json::to_string_pretty(&expected).unwrap() + ); + eprintln!( + "found = {}", + serde_json::to_string_pretty(empty_revealed.claims()).unwrap() ); + assert_eq!(*empty_revealed.claims(), expected); + let sub_sd_jwt = revealed .clone() .retaining(&[json_pointer!("/sub")]) @@ -142,37 +177,46 @@ async fn rfc_a_1_example_2_verification() { *sub_revealed.claims(), JWTClaims::builder() .sub("6c5c0a49-b589-431d-bae7-219122a9ec2c") - .iss("https://example.com/issuer") + .iss("https://issuer.example.com") .iat(1683000000) .exp(1883000000) .with_private_claims(Example2Claims::default()) .unwrap() ); - let address_sd_jwt = revealed + let country_sd_jwt = revealed .clone() - .retaining(&[json_pointer!("/address")]) + .retaining(&[json_pointer!("/address/country")]) .into_encoded(); - let (address_revealed, verification) = - address_sd_jwt.decode_reveal_verify(¶ms).await.unwrap(); + let (country_revealed, verification) = + country_sd_jwt.decode_reveal_verify(¶ms).await.unwrap(); assert_eq!(verification, Ok(())); - assert_eq!( - *address_revealed.claims(), - JWTClaims::builder() - .iss("https://example.com/issuer") - .iat(1683000000) - .exp(1883000000) - .with_private_claims(Example2Claims { - address: Some(Example2Address { - country: Some("JP".to_owned()), - ..Default::default() - }), + + let expected = JWTClaims::builder() + .iss("https://issuer.example.com") + .iat(1683000000) + .exp(1883000000) + .with_private_claims(Example2Claims { + address: Example2Address { + country: Some("JP".to_owned()), ..Default::default() - }) - .unwrap() + }, + ..Default::default() + }) + .unwrap(); + + eprintln!( + "expected = {}", + serde_json::to_string_pretty(&expected).unwrap() + ); + eprintln!( + "found = {}", + serde_json::to_string_pretty(country_revealed.claims()).unwrap() ); + + assert_eq!(*country_revealed.claims(), expected); } #[async_std::test] @@ -195,17 +239,27 @@ async fn rfc_a_2_example_3_verification() { #[derive(Debug, Default, Serialize, Deserialize, PartialEq)] struct VerificationEvidence { - #[serde(rename = "type")] + #[serde(rename = "type", skip_serializing_if = "Option::is_none")] _type: Option, + + #[serde(skip_serializing_if = "Option::is_none")] method: Option, + + #[serde(skip_serializing_if = "Option::is_none")] time: Option, + + #[serde(skip_serializing_if = "Option::is_none")] document: Option, } #[derive(Debug, Default, Serialize, Deserialize, PartialEq)] struct Verification { trust_framework: String, + + #[serde(skip_serializing_if = "Option::is_none")] time: Option, + + #[serde(skip_serializing_if = "Option::is_none")] verification_process: Option, evidence: Vec, } @@ -226,11 +280,22 @@ async fn rfc_a_2_example_3_verification() { #[derive(Debug, Default, Serialize, Deserialize, PartialEq)] struct VerifiedClaimsClaims { + #[serde(skip_serializing_if = "Option::is_none")] given_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] family_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] nationalities: Option>, + + #[serde(skip_serializing_if = "Option::is_none")] birthdate: Option, + + #[serde(skip_serializing_if = "Option::is_none")] place_of_birth: Option, + + #[serde(skip_serializing_if = "Option::is_none")] address: Option
, } @@ -243,8 +308,14 @@ async fn rfc_a_2_example_3_verification() { #[derive(Debug, Default, Serialize, Deserialize, PartialEq)] struct Example3Claims { verified_claims: VerifiedClaims, + + #[serde(skip_serializing_if = "Option::is_none")] birth_middle_name: Option, + + #[serde(skip_serializing_if = "Option::is_none")] salutation: Option, + + #[serde(skip_serializing_if = "Option::is_none")] msisdn: Option, } @@ -318,7 +389,7 @@ async fn rfc_a_2_example_3_verification() { assert_eq!( *revealed.claims(), JWTClaims::builder() - .iss("https://example.com/issuer") + .iss("https://issuer.example.com") .iat(1683000000) .exp(1883000000) .with_private_claims(Example3Claims {