Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ethers to a dependency rather than a peerDependency #151

Open
MidnightLightning opened this issue Mar 14, 2023 · 0 comments
Open

Move ethers to a dependency rather than a peerDependency #151

MidnightLightning opened this issue Mar 14, 2023 · 0 comments

Comments

@MidnightLightning
Copy link

For both the v1 branch and the v2-beta branch, the ethers library is marked as a peerDependency of the siwe package (in package.json). The usage of peerDependencies is used for packages that have a "plugin"-style architecture that need the things they extend to be installed "alongside" them rather than "under" them (documentation).

The siwe package uses the Ethers library's utility functions, but does not appear to add to the Ethers object (it's not a plugin for Ethers) and it doesn't return any Ethers-style objects (e.g. doesn't return an Ethers provider or Contract to the client). So, I believe ethers should be defined as a dependency rather than a peerDependency. Moving ethers to a dependency would allow siwe to use whatever version of ethers it wants (e.g. an older or newer version than what the implementing client app uses).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant