Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quilmes #8

Open
wants to merge 15 commits into
base: quilmes
Choose a base branch
from
Open

Quilmes #8

wants to merge 15 commits into from

Conversation

ColinCampbell
Copy link
Contributor

Some changes I've made. The only thing I would think that won't be ready for primetime is the polymorphic relationship stuff.

…container views inside of it, rather than just its own direct descendant
…ssue where going back to a view that had already been scrolled did not display its correct position
…class names, e.g., if controlsHidden changed to false, the controls-hidden class would not be removed
@wagenet
Copy link
Contributor

wagenet commented Sep 7, 2010

This all loooks good to me. Though I think someone else should review it since there are a lot of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants