Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing sitemap.xml raises a few errors #110

Open
loicteixeira opened this issue Jan 31, 2018 · 3 comments
Open

Accessing sitemap.xml raises a few errors #110

loicteixeira opened this issue Jan 31, 2018 · 3 comments
Labels

Comments

@loicteixeira
Copy link
Contributor

Key Error

See MADEWITHWAGTAIL-6 and MADEWITHWAGTAIL-7 on Sentry.

In this context, request isn't available here:

'request': context['request'],

This should be replaced with `context.get('request')

Note that the template uses the request here

{% if not request.path == '/search/' %}

So we probably need to change the condition to {% if not request or not request.path == '/search/' %}

Although to be fair I'm a bit puzzled that this is run when sitemap.xml is requested. Maybe it reached this point as a fallback of the following issue.

TemplateDoesNotExists

See MADEWITHWAGTAIL-5 on Sentry.

The sitemap.xml template is not found.

@mojeto
Copy link
Contributor

mojeto commented Jan 31, 2018

request template context processor is in place. context['request'] shouldn't fail in this configuration.

@mojeto
Copy link
Contributor

mojeto commented Jul 30, 2018

Sentry issue: MADEWITHWAGTAIL-6

@mojeto
Copy link
Contributor

mojeto commented Jul 30, 2018

Maybe related with: MADEWITHWAGTAIL-Fh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants