Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WebClientIntegrationTest to accommodate ReactorClientHttpRequest channel disassociation #33909

Closed
bclozel opened this issue Nov 18, 2024 · 0 comments
Closed

Refactor WebClientIntegrationTest to accommodate ReactorClientHttpRequest channel disassociation #33909

bclozel opened this issue Nov 18, 2024 · 0 comments
Assignees
@simonbasle
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone
6.2.1

Comments

@bclozel
Copy link
Member

bclozel commented Nov 18, 2024 •
edited by simonbasle
Loading

As noticed by Simon, there might be issues with the way we associate our Reactor request support with the Reactor channel vs. Netty channel. This might be the reason some WebClientIntegrationTests are flaky.

After further investigation, this is due to the fact that the Channel is overwritten with a static one after the processing of the request to avoid usage of an outdated pooled connection/channel (see reactor/reactor-netty#3459).

This is a test issue, and we should capture something else than the native request. Perhaps the Attribute or the Channel.
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels Nov 18, 2024
@bclozel bclozel added this to the 6.2.x milestone Nov 18, 2024
bclozel added a commit that referenced this issue Nov 18, 2024
@bclozel
Temporarily disable flaky integration test
afef439 
See gh-33909
@simonbasle simonbasle changed the title Review ReactorClientHttpRequest channel association Refactor WebClientIntegrationTest to accommodate ReactorClientHttpRequest channel disassociation Nov 18, 2024
@simonbasle simonbasle modified the milestones: 6.2.x, 6.2.1 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
6.2.1
Development

No branches or pull requests
2 participants
@bclozel @simonbasle