JettyWebSocketSession.getRemoteAddress throws IllegalArgumentException on a erroring-out session in 5.3.x versions #33619
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
status: declined
A suggestion or change that we don't feel we should currently apply
We have some custom observability code added to Web Socket Connection lifecycle.
The following exception happens when we try to call getRemoteAddress() on an erroring-out and closing session.
Expected
It's clearly not an intended behavior of
getRemoteAddress
method to throw on null here, especially taking into account thatWebSocketSession#getRemoteAddress
is explicitly marked an@Nullable
Environment
Spring 5.3.x and Jetty 10
This doesn't reproduce on Spring 5.2.x and 6+.
The text was updated successfully, but these errors were encountered: