Worst Logger for #mongoTemplate.find

[xjward]

debug code, :

Query query=Query.query(new Criteria().orOperator(
        Criteria.where("sendUserCode").is("aa"),Criteria.where("sendUserCode").is("bb")
));
query.with(Sort.by(Sort.Order.desc("sendTime")));
final List<CoEntity> coList = mongoTemplate.find(query,CoEntity.class);

debug step in main branches : MongoTemplate#find

protected <S, T> List<T> doFind(String collectionName,
	CollectionPreparer<MongoCollection<Document>> collectionPreparer, Document query, Document fields,
	Class<S> entityClass, @Nullable CursorPreparer preparer, DocumentCallback<T> objectCallback) {

MongoPersistentEntity<?> entity = mappingContext.getPersistentEntity(entityClass);

QueryContext queryContext = queryOperations.createQueryContext(new BasicQuery(query, fields));
Document mappedFields = queryContext.getMappedFields(entity, EntityProjection.nonProjecting(entityClass));
Document mappedQuery = queryContext.getMappedQuery(entity);

if (LOGGER.isDebugEnabled()) {

	Document mappedSort = getMappedSortObject(query, entityClass);
	LOGGER.debug(String.format("find using query: %s fields: %s sort: %s for class: %s in collection: %s",
			serializeToJsonSafely(mappedQuery), mappedFields, serializeToJsonSafely(mappedSort), entityClass,
			collectionName));
}

return executeFindMultiInternal(new FindCallback(collectionPreparer, mappedQuery, mappedFields, null),
		preparer != null ? preparer : CursorPreparer.NO_OP_PREPARER, objectCallback, collectionName);
}

focus code:

Document mappedSort = getMappedSortObject(query, entityClass);
serializeToJsonSafely(mappedSort)

expect
sort: { "sendTime" : -1}
but
sort: { "$or" : [{ "sendUserCode" : "aa"}, { "sendUserCode" : "bb"}]}

[mp911de]

Feel free to submit a pull request. It would also make sense to cross-check with the reactive implementation.

[florianluediger]

This is reproducible with the findByWithSortByScoreViaPageRequestTriggersSortingCorrectly test method for example. The problem here is that inside of the doFind method, there is no access to the sort information directly anymore. The query document seems to only contain the filter information at this point. Depending on the implementation, the sort information is available in the preparer, but it is not accessible directly because of the interface. Seems to me that some larger refactoring is necessary here and there is no way to fix this with little intrusion.

Some references:

• Logging of the sort attribute was introduced in Add logging a sort options for find queries #4679
• The PR Feature/sort logging #4794 demonstrates the issue and contains a comment with a suggested approach by @mp911de