Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining optional usage of org.json:json #8710

Closed
wilkinsona opened this issue Mar 24, 2017 · 4 comments
Closed

Remove remaining optional usage of org.json:json #8710

wilkinsona opened this issue Mar 24, 2017 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

We still have an optional dependency on org.json:json as it's used by JsonJsonParser (one of several JsonParser implementations that we provide. I think it's probably more trouble that it's worth (see #8706, for example).

I think we should remove our use of org.json:json and either update JsonJsonParser to use one of the clean room implementations, or just get rid of it entirely.

@wilkinsona
Copy link
Member Author

@wilkinsona wilkinsona added for: team-attention An issue we'd like other members of the team to review type: enhancement A general enhancement labels Mar 24, 2017
@philwebb
Copy link
Member

philwebb commented Mar 27, 2017

I'd be in favor of dropping the JsonJsonParser but we still have a dependency on JSONAssert which uses:

<groupId>com.vaadin.external.google</groupId>
<artifactId>android-json</artifactId>
<version>0.0.20131108.vaadin1</version>

So I'm not sure removing our managed dependency would fix #8706

@wilkinsona
Copy link
Member Author

On closer inspection I don't think it would either. I'd misread the problem as being due to our dependency management pulling in a version of org.json:json that's too old.

@philwebb philwebb added this to the 2.0.0.M1 milestone Mar 30, 2017
@wilkinsona
Copy link
Member Author

We've decided to drop JsonJsonParser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants