Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcontainer Redis with having ssl:true in application.yml #43977

Open
Tracked by #41137
Xyaren opened this issue Jan 27, 2025 · 1 comment
Open
Tracked by #41137

Testcontainer Redis with having ssl:true in application.yml #43977

Xyaren opened this issue Jan 27, 2025 · 1 comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone

Comments

@Xyaren
Copy link

Xyaren commented Jan 27, 2025

Spring Boot: 3.4.2

I just started using a redis testcontainer and notice that using @ServiceConnection does take the spring.data.redis.ssl.enabled property from application.yml into account.
My expectation would be, that the @ServiceConnection will overrule the default config in this case, like it does for host, port etc.
org.springframework.boot.autoconfigure.data.redis.RedisConnectionDetails has no property to allow enabling/disabling ssl.

@wilkinsona
Copy link
Member

This is something that connection details, and therefore @ServiceConnection, does not yet support. #41137 is tracking some cross-cutting changes that the support for each specific service, such as Redis, could then build upon.

In the meantime, the assumption is that you will want to use SSL so that you can test that the app's client-side SSL configuration is correct and that it can establish a secure connection to Redis over SSL. You can use the properties attribute on @SpringBootTest or @TestPropertySource to disable SSL if this isn't what you want.

@wilkinsona wilkinsona added type: enhancement A general enhancement status: pending-design-work Needs design work before any code can be developed and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 27, 2025
@wilkinsona wilkinsona added this to the 3.x milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants