Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrometheusPushGatewayManager to use the new Prometheus client #43923

Open
wilkinsona opened this issue Jan 22, 2025 · 0 comments
Open
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

Support for Prometheus's simple client was deprecated in #40023. As part of that, we should have deprecated PrometheusPushGatewayManager as it has public API that depends upon types from Simpleclient. This deprecation will then pave the way for introducing support for the Push Gateway with the new Prometheus Client.

Initially the new Prometheus Client didn't support the push gateway but support was introduced in 1.3. We upgraded to 1.3 of the new client in Boot 3.4 but overlooked the fact that the push gateway was now supported. We'll need to decide how best to deal with this to minimise disruption. Strictly speaking, it's too late to deprecate PrometheusPushGatewayManager for removal/breaking changes in 3.5. However, the alternative would be to keep the manager in a form that depends on the simple client that we no longer support.

There are also some configuration property changes to consider. For example, we have a property for the push gateway's url but this is now configured as an address (host:port) and a separate scheme (http or https). Passing in a url like http://prometheus.example.com as the address results in a failure as it's considered to be malformed.

@wilkinsona wilkinsona added the type: bug A general bug label Jan 22, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Jan 22, 2025
@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 22, 2025
@bclozel bclozel modified the milestones: 3.3.x, 3.5.x Jan 29, 2025
@bclozel bclozel added type: enhancement A general enhancement and removed type: bug A general bug for: team-meeting An issue we'd like to discuss as a team to make progress labels Jan 29, 2025
@bclozel bclozel changed the title PrometheusPushGatewayManager should have been deprecated alongside deprecation of other Simpleclient support Update PrometheusPushGatewayManager to use the new Prometheus client Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants