Spring Boot 3.4-M3: application container does not start when TestContainer beans depend on each other #42607
Labels
status: duplicate
A duplicate of another issue
Comments
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the sample. I can reproduce the problem with 3.4.0-M3 but not with 3.4.0-SNAPSHOT. I suspect that's due to some of the changes that were made in #41996 where the container lifecycle management was simplified. For reference, here's the log with 3.4.0-SNAPSHOT when the test starts the app successfully: Please given 3.4.0-SNAPSHOT (available from https://repo.spring.io/snapshot) a try and let us know if it works in your actual application as well as the sample. |
wilkinsona
added
the
status: waiting-for-feedback
|
Hi @wilkinsona , thanks for getting back so quickly! Indeed my test works with 3.4.0-SNAPSHOT 🥳. Anyway, may I ask you a question if this (dummy) code is the correct way to got when setting up containers with dependencies and also using dynamic properties from the containers for the application context? I found a lot of different ways, but that one would look like the most "spring-ish" way to me: @TestConfiguration
public class MyContainerConfig {
@Bean
Network dockerNetwork() {
return Network.newNetwork();
}
@Bean
@ServiceConnection
@Primary
PostgreSQLContainer<?> postgresContainer(Network network) {
return new PostgreSQLContainer<>(DockerImageName.parse("postgres:16-alpine"))
// ... more options ...
;
}
@Bean
@DependsOn({"postgresContainer"})
KeycloakContainer keycloakContainer(Network network) {
return new KeycloakContainer()
// ... more options ...
;
}
@Bean
DynamicPropertyRegistrar keycloakPropertiesRegistrar(KeycloakContainer container) {
return registry -> {
// add dynamic keycloak properties to application context
registry.add("my.keycloak-admin.url", container::getAuthServerUrl);
// ... more properties ...
};
}
} |
spring-projects-issues
added
status: feedback-provided
|
Yes, as of 3.4 (only in 3.4.0-SNAPSHOT at the moment), that's the preferred way to do it. Specifically, when containers are defined as beans, using a Thanks very much for trying out the snapshot and letting us know things are working again. I'll close this one as a duplicate of #41996. |
wilkinsona
added
status: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrading a Spring Boot 3.3.4 project to Spring Boot 3.4-M3 i encountered a changed behaviour when defining two TestContainer beans that depend on each other and using a third (ServletFilter) Bean that (indirectly) consumes the application's
DataSource.Reproducible setup
Containerbeans in my@TestConfigurationclass. One of them providing theServiceConnectionfor my DataSource.@DependsOnannotation to mark a dependency on the other container:@Beanmethod that registeres a ServletFilter-Bean. The methods expects aJdbcClientas parameterJdbcClientis not really used here (as opposed to my real application), but it's enough just to add it here as a method param to make the application start failingChanged Behaviour
I have created a repository with two versions of the same application for Spring Boot 3.3 and 3.4. The only difference is the pom.xml-file: https://github.com/nilshartmann/testcontainer-example
You can see the problem when running the
TestcontainerExampleApplicationTestsin both3_3and3_4subfolders.If you either remove the
@DependsOnannotation or remove theJdbcClientfrom thefilterOnemethod the application starts (unfortunately in my real application I cannot remove one of this two...).Thanks for any help!
The text was updated successfully, but these errors were encountered: