Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how to support spring.integration.keep-alive #42469

Open
philwebb opened this issue Sep 27, 2024 · 1 comment
Open

Consider how to support spring.integration.keep-alive #42469

philwebb opened this issue Sep 27, 2024 · 1 comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

Spring Integration is introducing a new spring.integration.keep-alive property which will create a keep-alive thread based on this logic. We could surface this property in Spring Boot, however, we already have spring.main.keep-alive.

We need to consider what we should do by default, specifically:

  • If spring.main.keep-alive is true then there is no need to Spring Integration to create a thread
  • If spring.main.keep-alive is missing then standard Spring Integration logic should apply
  • If spring.main.keep-aliveis false we may need to also disable Spring Integration keep alive
  • If we don't do the above, we need to offer a way to turn off Spring Integration keep alive threads
@philwebb philwebb added status: pending-design-work Needs design work before any code can be developed for: team-meeting An issue we'd like to discuss as a team to make progress labels Sep 27, 2024
@philwebb philwebb added this to the 3.4.x milestone Sep 27, 2024
@philwebb
Copy link
Member Author

See spring-projects/spring-integration#9455 for the original request. We need some more time to consider our options portfolio wide so we'll need to look at this after 3.4

@philwebb philwebb modified the milestones: 3.4.x, 3.5.x Sep 30, 2024
@wilkinsona wilkinsona removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 9, 2024
@snicoll snicoll added the type: enhancement A general enhancement label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants