Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to stabilize ZipkinWebClientSenderTests #42375

Closed
wilkinsona opened this issue Sep 19, 2024 · 2 comments
Closed

Try to stabilize ZipkinWebClientSenderTests #42375

wilkinsona opened this issue Sep 19, 2024 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task

Comments

@wilkinsona
Copy link
Member

Several tests are flaky on CI. We should try to stabilize them.

@wilkinsona wilkinsona added the type: task A general task label Sep 19, 2024
@wilkinsona wilkinsona added this to the 3.2.x milestone Sep 19, 2024
@wilkinsona wilkinsona self-assigned this Sep 19, 2024
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.11 Sep 19, 2024
@wilkinsona
Copy link
Member Author

wilkinsona commented Sep 20, 2024

This hasn't helped:

reactor.core.Exceptions$ReactiveException: java.util.concurrent.TimeoutException: Did not observe any item or terminal signal within 60000ms in 'flatMap' (and no fallback has been configured)	
	at reactor.core.Exceptions.propagate(Exceptions.java:410)	
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:102)	
	at reactor.core.publisher.Mono.block(Mono.java:1779)	
	at org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinWebClientSender$WebClientHttpPostCall.doExecute(ZipkinWebClientSender.java:76)	
	at org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinWebClientSender$WebClientHttpPostCall.doExecute(ZipkinWebClientSender.java:54)	
	at zipkin2.Call$Base.execute(Call.java:391)	
	at org.springframework.boot.actuate.autoconfigure.tracing.zipkin.HttpSender.check(HttpSender.java:72)	
	at org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinWebClientSenderTests.checkShouldNotRaiseException(ZipkinWebClientSenderTests.java:104)

I'm going to revert that change as, when the problem occurs, the build now takes longer as it waits for 60 seconds.

Looking more closely at Develocity's test dashboard, the flakiness appears to be limited to 3.2.x and way more common on Windows than Linux. Of the 43 flaky test runs in the last 28 days, 42 of them have occurred on Windows and 1 on Linux.

@wilkinsona wilkinsona reopened this Sep 20, 2024
wilkinsona added a commit that referenced this issue Sep 20, 2024
@wilkinsona wilkinsona modified the milestones: 3.2.11, 3.2.x Sep 20, 2024
@wilkinsona
Copy link
Member Author

The latest results show the problem occurring on 3.2.x, 3.3.x, and main with a more even split between Windows and Linux. Unfortunately, I can't reproduce locally and haven't found a way to address the flakiness on CI. I think we'll have to live with this for now.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
@wilkinsona wilkinsona removed this from the 3.2.x milestone Nov 4, 2024
@wilkinsona wilkinsona added the status: declined A suggestion or change that we don't feel we should currently apply label Nov 4, 2024
@wilkinsona wilkinsona removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant