Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider if we want a property to add an AnnotationTemplateExpressionDefaults bean #42202

Closed
philwebb opened this issue Sep 10, 2024 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@philwebb
Copy link
Member

Watching https://youtu.be/9eoi1TViceM?t=2188 it might be useful if we offered a quick way to register a PrePostTemplateDefaults (deprecated and replaced by AnnotationTemplateExpressionDefaults) bean. Perhaps as a property.

@philwebb philwebb added status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Sep 10, 2024
@wilkinsona wilkinsona changed the title Consider if we want a property to add a AnnotationTemplateExpressionDefaults bean Consider if we want a property to add an AnnotationTemplateExpressionDefaults bean Sep 11, 2024
@philwebb
Copy link
Member Author

It looks like this code reacts to the bean and there is a difference when the bean is present or not.

I think that gives us two potential properties, one for doing placeholder replacement and another for ignoring unknown placeholders.

Given the potential complexity, I think we should not do anything until Spring Security users ask for this feature.

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

1 participant