-
Notifications
You must be signed in to change notification settings - Fork 40.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use configuration resolver to replace standard resolver
Closes gh-28687
- Loading branch information
Showing
5 changed files
with
121 additions
and
7 deletions.
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
...amework/boot/autoconfigure/context/ConfigurationPropertySourcesPlaceholderConfigurer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright 2012-2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.autoconfigure.context; | ||
|
||
import org.springframework.boot.context.properties.source.ConfigurationPropertySources; | ||
import org.springframework.context.support.PropertySourcesPlaceholderConfigurer; | ||
import org.springframework.core.env.ConfigurablePropertyResolver; | ||
import org.springframework.core.env.MutablePropertySources; | ||
|
||
/** | ||
* Placeholder configurer that resolves using the optimized | ||
* {@link ConfigurablePropertyResolver}. | ||
* | ||
* @author Guirong Hu | ||
*/ | ||
class ConfigurationPropertySourcesPlaceholderConfigurer extends PropertySourcesPlaceholderConfigurer { | ||
|
||
// @Override | ||
protected ConfigurablePropertyResolver createPropertyResolver(MutablePropertySources propertySources) { | ||
return ConfigurationPropertySources.createPropertyResolver(propertySources); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
...rk/boot/autoconfigure/context/ConfigurationPropertySourcesPlaceholderConfigurerTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* | ||
* Copyright 2012-2023 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.autoconfigure.context; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.springframework.beans.BeansException; | ||
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory; | ||
import org.springframework.boot.context.properties.source.ConfigurationPropertySources; | ||
import org.springframework.boot.test.context.runner.ApplicationContextRunner; | ||
import org.springframework.context.annotation.Bean; | ||
import org.springframework.context.annotation.Configuration; | ||
import org.springframework.core.env.ConfigurablePropertyResolver; | ||
import org.springframework.core.env.MutablePropertySources; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Tests for {@link ConfigurationPropertySourcesPlaceholderConfigurer}. | ||
* | ||
* @author Guirong Hu | ||
*/ | ||
class ConfigurationPropertySourcesPlaceholderConfigurerTests { | ||
|
||
@Test | ||
void propertyResolverIsOptimizedForPropertyPlaceholder() { | ||
ConfigurablePropertyResolver expected = ConfigurationPropertySources | ||
.createPropertyResolver(new MutablePropertySources()); | ||
|
||
new ApplicationContextRunner().withUserConfiguration(GetPropertyResolverPlaceholderConfigurerConfig.class) | ||
.run((context) -> assertThat( | ||
context.getBean(GetPropertyResolverPlaceholderConfigurer.class).getPropertyResolver()) | ||
.hasSameClassAs(expected)); | ||
} | ||
|
||
@Configuration(proxyBeanMethods = false) | ||
static class GetPropertyResolverPlaceholderConfigurerConfig { | ||
|
||
@Bean | ||
static GetPropertyResolverPlaceholderConfigurer getPropertyResolverPlaceholderConfigurer() { | ||
return new GetPropertyResolverPlaceholderConfigurer(); | ||
} | ||
|
||
} | ||
|
||
static class GetPropertyResolverPlaceholderConfigurer extends ConfigurationPropertySourcesPlaceholderConfigurer { | ||
|
||
private ConfigurablePropertyResolver propertyResolver; | ||
|
||
@Override | ||
protected void processProperties(ConfigurableListableBeanFactory beanFactoryToProcess, | ||
ConfigurablePropertyResolver propertyResolver) throws BeansException { | ||
this.propertyResolver = propertyResolver; | ||
super.processProperties(beanFactoryToProcess, propertyResolver); | ||
} | ||
|
||
public ConfigurablePropertyResolver getPropertyResolver() { | ||
return this.propertyResolver; | ||
} | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters