GH-4703: Enhance StoppableTasklet interface to support step-specific stop requests #4715
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyunSangHan
commented
Nov 24, 2024
Comment on lines
+50
to
+52
| default void stop(StepExecution stepExecution) { | ||
| stop(); | ||
| } |
There was a problem hiding this comment.
The new method provides a default implementation that delegates the call to the existing stop() method, ensuring backward compatibility for implementations that do not need step-specific stopping logic.
If you have any suggestions for improvement, please feel free to provide feedback!
HyunSangHan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4703
Resolves a limitation in the
StoppableTaskletinterface where distinguishing which specific StepExecution to stop was not possible during concurrent job executions.