Skip to content

Would Refactoring Long Methods in Bedrock Converse API Be Acceptable? #1814

Open
@cowboysj

Description

@cowboysj

I’ve been a regular and enthusiastic user of Spring AI, and I’ve always appreciated its capabilities. When I previously asked about Bedrock API support, I was told that the Converse API release was in preparation, and I’ve been eagerly awaiting its availability ever since.

Now that the Bedrock Converse API is supported, I’ve noticed that some methods in BedrockProxyChatModel and ConverseApiUtils, such as createRequest and toChatResponse, are quite lengthy and handle multiple responsibilities. Refactoring these into smaller, focused methods could improve readability, maintainability, and testability.

Request

Would it be acceptable for me to refactor these methods while ensuring existing functionality and backward compatibility remain intact? I’d like to proceed only if it aligns with the project’s guidelines and maintainers' approval. Thank you! 😆

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions