Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServer 2017 tests failing #5952

Open
onobc opened this issue Sep 23, 2024 · 2 comments
Open

SqlServer 2017 tests failing #5952

onobc opened this issue Sep 23, 2024 · 2 comments
Labels
area/tests Belongs to tests
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented Sep 23, 2024

Determine why the following tests are failing and re-enable the disabled tests.

Annotations
4 errors and 6 warnings
org.springframework.cloud.dataflow.server.db.migration.SqlServer_2017_SmokeTest ► : spring-cloud-dataflow-test/src/main/java/org/springframework/cloud/dataflow/server/db/arm64/SqlServerArm64ContainerSupport.java#L51
Failed test found in:
spring-cloud-dataflow-server/target/surefire-reports/TEST-org.springframework.cloud.dataflow.server.db.migration.SqlServer_2017_SmokeTest.xml
Error:
org.testcontainers.containers.ContainerLaunchException: Container startup failed for image mcr.microsoft.com/mssql/server:2017-latest
org.springframework.cloud.dataflow.server.db.support.DatabaseTypeTests$SqlServer_2017_DatabaseTypeTests ► : spring-cloud-dataflow-test/src/main/java/org/springframework/cloud/dataflow/server/db/arm64/SqlServerArm64ContainerSupport.java#L51
Failed test found in:
spring-cloud-dataflow-server/target/surefire-reports/TEST-org.springframework.cloud.dataflow.server.db.support.DatabaseTypeTests$SqlServer_2017_DatabaseTypeTests.xml
Error:
org.testcontainers.containers.ContainerLaunchException: Container startup failed for image mcr.microsoft.com/mssql/server:2017-latest

main:
https://github.com/spring-cloud/spring-cloud-dataflow/actions/runs/10994471927

@onobc onobc added the area/tests Belongs to tests label Sep 23, 2024
@onobc onobc added this to the 3.0.x milestone Sep 23, 2024
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Sep 23, 2024
onobc added a commit that referenced this issue Sep 24, 2024
@corneil
Copy link
Contributor

corneil commented Sep 27, 2024

There was a recent update to latest but there is no other 2017 tag with the same date.
2017-CU31-GDR2-ubuntu-18.04 also gives errors. There may be a breaking change to org.testcontainers:mssqlserver.
Either way I don't believe we need to try and support a 7 year old commercial database version in the OSS project.

@cppwfs
Copy link
Contributor

cppwfs commented Sep 27, 2024

Are there other tests we need to drop as well because of the age of the DB version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Belongs to tests
Projects
None yet
Development

No branches or pull requests

3 participants